Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for authenticating non-GitHub remotes #852

Closed
shiftkey opened this issue Jan 25, 2017 · 30 comments
Closed

Support for authenticating non-GitHub remotes #852

shiftkey opened this issue Jan 25, 2017 · 30 comments
Assignees

Comments

@shiftkey
Copy link
Member

This is an open discussion what we should target for the beta, if anything. We can spin off specific tasks and put those into the appropriate milestones.

Some things that should cover most of the use cases we've seen based on Desktop Classic:

  • let the user specify credentials when an authentication fails?
  • managing credentials - list stored creds, let user remove

Aside from that, if we're keen to do this we'd need to update our getUserForRepository lookup to be more flexible (e.g. if not marked as a GitHub repository, lookup for credentials by the remote URL)

@joshaber
Copy link
Contributor

I don't think we need to for beta, but maybe for 1.0.

Anyone feel strongly this should be in beta?

@MatthewFrench
Copy link

It would be very nice to have this. At the moment I have both a git bash and desktop open. Desktop for visuals and bash to push changes. Can't push changes from desktop until authorization is working.

@blogcraft
Copy link

@joshaber When you go to Github Desktop The first thing that appears is the Beta, and hidden in the bottom is the current one. So, yeah, it might be a beta, but it is promoted as a first choice. So non-GitHub support is to be expected.

@bjcull
Copy link

bjcull commented Jun 2, 2017

I use both Github and VSTS repos with classic quite often. I was a little disappointed to find I can't use this for VSTS. Is a stop-gap of calling the underlying git commands feasible? git push works just fine from the shell.

@tech4him1
Copy link

tech4him1 commented Jun 6, 2017

I don't think this is necessary right away, but I still think it is very important if GitHub Desktop is going to really be used as more than a hobby tool.

@fengsong97
Copy link

fengsong97 commented Jun 14, 2017

今天更新了 deskTop客户端,一直挺喜欢这个客户端的, 但是这次更新发现,如果不是 github 仓库的话 , 就无法pull 和 push ,需要认证,但是却没有提供认证界面,
这真的让人失望 ,希望开发人员能够快点解决这个问题。

Today updated the deskTop client, I has always liked this client, but this update found that if it is not GitHub warehouse, you will can not pull and push, you need authentication, but it did not provide authentication interface,
It's really disappointing, and I hope developers can work it out quickly.

image

@mikeytusa
Copy link

mikeytusa commented Jun 24, 2017

Definitely need to be able to use this with non-GitHub repos. Works fine on my Mac. Authentication fails on Windows.

@felschr
Copy link

felschr commented Jul 1, 2017

I really like GitHub Desktop but I also have to work with VSTS, Bitbucket & GitLab at work for different projects and it would be nice if GitHub Desktop would support that as well.

@fengsong97
Copy link

fengsong97 commented Jul 5, 2017

The GithubDeskTop of old version link for non-GitHub can be supported .
example: oschina.com gitlab .....

链接:http://pan.baidu.com/s/1jH4l3Lk 密码password : v9ag

@47ronin
Copy link

47ronin commented Jul 5, 2017

Confirmed that the beta cannot properly authenticate against Pantheon Drush repos in order to clone dev projects. It doesn't error out. It just throws a never-ending spinner icon in the dialog.

@felschr
Copy link

felschr commented Jul 6, 2017

My dream would be that GitLab, Bitbucket, etc. get first level integrations including OAuth login, repository browser (when the feature is added: #57) and maybe some of other website integrations like branch comparing, viewing the repository, opening a commit.

But as this is a product by GitHub itself this is probably just a wish that will never come true.

@mikeytusa
Copy link

On a PC it doesn't support SSH. Works over HTTPS. It works on Mac though. Not sure why it hasn't been implemented yet on a PC.

@HedvigS
Copy link

HedvigS commented Sep 29, 2017

Thanks @mikeytusa . How does it work on a mac?

@shiftkey
Copy link
Member Author

shiftkey commented Oct 2, 2017

For those who are looking at SSH support, we're tracking the current pain points over here #2579.

If you're using HTTPS, the work done to support basic credentials from other providers has landed in 1.0.

@47ronin
Copy link

47ronin commented Oct 10, 2017

Seeing a new ssh-askpass error when attempting to fetch/sync in the new GitHub desktop app?

If you are using macOS 10.13 High Sierra and /usr/X11R6 disappeared, don't panic. Yes it's gone and symbolic linking in /usr cannot be done due to SIP. There is a simple workaround:
theseal/ssh-askpass#18 (comment)

@mmccarn
Copy link

mmccarn commented Jul 4, 2018

I connected github desktop to a local gitlab server as follows:

  • install github desktop for windows 64-bit v1.2.6
  • install git version 2.18.0.windows.1
  • create a Personal Access Token [https://gitlab.mydomain.com/profile/personal_access_tokens] in gitlab for API access
  • create a 'Project' in gitlab to contain your new repository. For empty projects, gitlab displays instructions on the Project Details page explaining how to connect your project to another git instance, including these instructions for connecting to an existing folder:
cd existing_folder
git init
git remote add origin https://gitlab.mydomain.com/path/to-your-project.git
git add .
git commit -m "Initial commit"
git push -u origin master
  • use the access token name and password as the username and password when prompted to connect
  • (Windows) - if you get a login error without being prompted for a username and password, open "manage your credentials" in Control Panel, select "Windows Credentials", then find and edit the credentials for your gitlab server.

If you now connect to this repository in Github Desktop it is properly configured to communicate with your gitlab server. The first time you push or pull to the server you will need to enter the same API Token credentials that were used in the git command line above.

(Note: I may have been required to do this using a personal access token because my gitlab server has mandatory 2 factor authentication enabled)

@lock lock bot locked as resolved and limited conversation to collaborators Sep 2, 2018
@desktop desktop unlocked this conversation Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests