Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting an Emoji as Name triggers error on blur #8534

Closed
hiddendragonXVII opened this issue Oct 26, 2019 · 3 comments · Fixed by #8541
Closed

Setting an Emoji as Name triggers error on blur #8534

hiddendragonXVII opened this issue Oct 26, 2019 · 3 comments · Fixed by #8541
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature

Comments

@hiddendragonXVII
Copy link

hiddendragonXVII commented Oct 26, 2019

Describe the bug

I set my Commit name to an Emoji
and then when i go to edit my email it crashes

Version & OS

Tested on OS X and Windows

Steps to reproduce the behavior

  1. Go to Github commit settings
  2. Click on name and put in an emoji 🧙
  3. down to click on email
  4. See error

Expected behavior

edit the email
A clear and concise description of what you expected to happen.

Actual behavior

Error: value must be a single character at Object.n [as fatalError] (file:///app/renderer.js:1:1753) at o (file:///app/renderer.js:16:594244) at Object.t.disallowed Characters (file:///app/renderer.js:16:594543) at C.disallowed Character ErrorMessage (file:///app/renderer.js:16:605654) at Object.C.onCommitterNameChanged [as onValueChanged] (file:///app/renderer.js:16:602110) at d. (file:///app/renderer.js:11:26012) at Re (file:///app/renderer.js:27:20247) at commitLifeCycles (file:///app/renderer.js:27:44342) at L (file:///app/renderer.js:27:55807) at A (file:///app/renderer.js:27:54616)
A clear and concise description of what actually happened.

Screenshots

Add screenshots to help explain your problem, if applicable.

Logs

Attach your logs by opening the Help menu and selecting Show Logs..., if applicable.

Additional context

Add any other context about the problem here.

@Rexogamer
Copy link
Contributor

Hey! Can you tell us what version of Github Desktop you’re using? Go into Settings and select About Github Desktop.

@niik niik self-assigned this Oct 28, 2019
@niik niik added the bug Confirmed bugs or reports that are very likely to be bugs label Oct 28, 2019
@niik
Copy link
Member

niik commented Oct 28, 2019

Hey @thewizardwand, thanks for opening this! I've opened #8541 which should hopefully address this issue. As a workaround for now you can either manually set your name by modifying the .gitconfig file directly or by using git config --global user.name "🦸‍♂️" from a command line.

@hiddendragonXVII
Copy link
Author

Hey! Can you tell us what version of Github Desktop you’re using? Go into Settings and select About Github Desktop.

Version 2.2.2

Hey @thewizardwand, thanks for opening this! I've opened #8541 which should hopefully address this issue. As a workaround for now you can either manually set your name by modifying the .gitconfig file directly or by using git config --global user.name "🦸‍♂️" from a command line.

👍

@tierninho tierninho added the priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants