Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fork] "Create pull request" is still a suggestion even after I've created a PR for the current branch on my fork #8549

Closed
kuychaco opened this issue Oct 29, 2019 · 1 comment · Fixed by #8825 or #8868
Closed

[Fork] "Create pull request" is still a suggestion even after I've created a PR for the current branch on my fork #8549

kuychaco opened this issue Oct 29, 2019 · 1 comment · Fixed by #8825 or #8868
Assignees
@outofambit
Labels
epic:fork
Projects
Desktop 2.3 release

Comments

@kuychaco
Copy link
Contributor

kuychaco commented Oct 29, 2019 •
edited by billygriffin

Extracted from #8509 (Problem 2) for tracking work on this particular issue

Problem: "Create pull request" is still a suggestion even after I've created a pull request for the current branch on my fork

After you create a PR from a branch of your fork that's targeting the upstream repo, the "Create pull request" suggestion is still displayed. This is very confusing because you already have a PR.

Example: I'm in billygriffin/desktop (a fork of desktop/desktop) on my branch new-work, and I make some commits and create a pull request targeting the development branch of desktop/desktop. In the app, I'm still shown the "Create pull request" suggested next step even though I've already created one.
@kuychaco kuychaco added this to Backlog in Desktop 2.2.4 release via automation Oct 29, 2019
@kuychaco kuychaco moved this from Backlog to Prioritized backlog (ordered) in Desktop 2.2.4 release Oct 29, 2019
@outofambit outofambit self-assigned this Nov 15, 2019
@outofambit outofambit moved this from Prioritized backlog (ordered) to In Progress Issues in Desktop 2.2.4 release Nov 15, 2019
@outofambit outofambit mentioned this issue Nov 19, 2019
Closed
@outofambit outofambit removed this from In Progress Issues in Desktop 2.2.4 release Dec 5, 2019
@outofambit outofambit added this to Backlog (out of scope for release) in Desktop 2.3 release via automation Dec 5, 2019
@nerdneha nerdneha moved this from Backlog (unprioritized) to Prioritized backlog (ordered) in Desktop 2.3 release Dec 13, 2019
@outofambit outofambit mentioned this issue Dec 19, 2019
Merged
@outofambit outofambit moved this from Prioritized backlog (ordered) to In Progress Issues in Desktop 2.3 release Dec 20, 2019
@billygriffin billygriffin mentioned this issue Dec 30, 2019
Open
This was referenced Dec 30, 2019
Merged
Merged
Merged
Desktop 2.3 release automation moved this from In Progress Issues to Done! Jan 9, 2020
@outofambit
Copy link
Contributor

this was closed erroneously!

@outofambit outofambit reopened this Jan 11, 2020
Desktop 2.3 release automation moved this from Done! to In Progress Issues Jan 11, 2020
Desktop 2.3 release automation moved this from In Progress Issues to Done! Jan 15, 2020
@tierninho tierninho mentioned this issue Jan 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@outofambit outofambit

Labels
epic:fork
Projects
No open projects
Desktop 2.3 release
Done!
Milestone
No milestone
3 participants
@outofambit @kuychaco @tierninho