Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove input values for previous dialog until success for Clone a repository #8720

Open
Sairony opened this issue Nov 28, 2019 · 1 comment

Comments

@Sairony
Copy link

Sairony commented Nov 28, 2019

When cloning a repository using URL hitting Clone closes the dialog window & begins the cloning, this is dandy on success but if any of the inputs were wrong & you're presented with an error you have restart the process from the beginning.

It would be an improvement if instead you're taken back to the "Clone a repository" dialog again with exactly the same state as before you hit Clone.

As it is now it's kind of like to those websites where you submit a form, get presented with an error and it's cleared all your input fields.

@tierninho
Copy link
Contributor

@Sairony I tested this and the steps were as you described:

  • Clone a repo on the URL tab.
  • If error occurs, URL is cleared

Screen Shot 2019-12-02 at 11 34 09 AM
Screen Shot 2019-12-02 at 11 34 18 AM

I support repopulating the form with the URL however I suspect there are some complications with doing so that I am specifically unaware of.

One thing I want to warn against is the repopulating of the field if X amount of time has passed or if the tab is revisited later.

Leaving this open for other to weigh in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants