Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent false branch protection notices #8743

Closed
tierninho opened this issue Dec 4, 2019 · 0 comments · Fixed by #8784
Closed

Prevent false branch protection notices #8743

tierninho opened this issue Dec 4, 2019 · 0 comments · Fixed by #8784
Assignees
@kuychaco
Labels
bug Confirmed bugs or reports that are very likely to be bugs epic:branch-protection priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Projects
Desktop 2.2.4 release Desktop 2.3 release

Comments

@tierninho
Copy link
Contributor

Describe the bug

When navigating from a protected branch to a branch that hasn't been accessed in awhile, the branch protection notice flashes briefly even thought the target branch is not protected.

Version & OS

2.2.4-beta2 OSX

Steps to reproduce the behavior

  1. Go to protected branch in your repo
  2. Select a branch that hasn't been accessed in awhile
  3. Notice the branch protection warning shows for 1 sec.

Expected behavior

The warning should not show on the target branch

Actual behavior

The warning flashes on the target branches, confusing the user

Screenshots

Screen Shot 2019-12-03 at 3 30 37 PM
@tierninho tierninho added bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature labels Dec 4, 2019
@outofambit outofambit added this to Backlog (out of scope for release) in Desktop 2.2.4 release via automation Dec 5, 2019
@kuychaco kuychaco self-assigned this Dec 11, 2019
@kuychaco kuychaco moved this from Backlog (out of scope for release) to In Progress Issues in Desktop 2.2.4 release Dec 11, 2019
@kuychaco kuychaco mentioned this issue Dec 12, 2019
Merged
@kuychaco kuychaco added this to Backlog (unprioritized) in Desktop 2.3 release via automation Dec 12, 2019
@kuychaco kuychaco moved this from Backlog (unprioritized) to In Progress Issues in Desktop 2.3 release Dec 12, 2019
Desktop 2.3 release automation moved this from In Progress Issues to Done! Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuychaco kuychaco

Labels
bug Confirmed bugs or reports that are very likely to be bugs epic:branch-protection priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Projects
No open projects
Desktop 2.2.4 release
In Progress Issues
Desktop 2.3 release
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove false branch protection warning when switching branches desktop/desktop
3 participants
@kuychaco @tierninho and others