Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching branches via Cmd line doesn't update branch protection #8790

Closed
tierninho opened this issue Dec 12, 2019 · 0 comments · Fixed by #8812
Closed

Switching branches via Cmd line doesn't update branch protection #8790

tierninho opened this issue Dec 12, 2019 · 0 comments · Fixed by #8812
Assignees
@kuychaco
Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-2 Bug that affects more than a few users in a meaningful way but doesn't prevent core functions
Projects
Desktop 2.3 release

Comments

@tierninho
Copy link
Contributor

If a user is switching between branches and goes from a protected branch to a unprotected branch via the command line, then Desktop fails to update the protected branch warning.

Repro:

  • Go to protected branch in Desktop
  • Use cmd line to swap branches to unprotected branch
  • Warning is intact

Note the situation can be reversed, ie if a user goes from an unprotected branch to protected branch that warning is missing.

Version 2.2.4, osx

cc @kuychaco @cheshire137
@tierninho tierninho added bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature labels Dec 12, 2019
@kuychaco kuychaco added this to Backlog (unprioritized) in Desktop 2.3 release via automation Dec 12, 2019
@nerdneha nerdneha moved this from Backlog (unprioritized) to Prioritized backlog (ordered) in Desktop 2.3 release Dec 13, 2019
@niik niik added priority-2 Bug that affects more than a few users in a meaningful way but doesn't prevent core functions and removed priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature labels Dec 13, 2019
@kuychaco kuychaco mentioned this issue Dec 18, 2019
Merged
@kuychaco kuychaco moved this from Prioritized backlog (ordered) to In Progress Issues in Desktop 2.3 release Dec 18, 2019
@kuychaco kuychaco self-assigned this Dec 18, 2019
Desktop 2.3 release automation moved this from In Progress Issues to Done! Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuychaco kuychaco

Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-2 Bug that affects more than a few users in a meaningful way but doesn't prevent core functions
Projects
No open projects
Desktop 2.3 release
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update branch protection state for checkout outside of Desktop desktop/desktop
4 participants
@niik @kuychaco @tierninho and others