Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fork] Add create fork flow entry point at commit warning #8938

Closed
outofambit opened this issue Jan 17, 2020 · 1 comment · Fixed by #8939
Closed

[Fork] Add create fork flow entry point at commit warning #8938

outofambit opened this issue Jan 17, 2020 · 1 comment · Fixed by #8939
Assignees
@outofambit
Labels
epic:fork
Projects
Desktop 2.3 release

Comments

@outofambit
Copy link
Contributor

The problem initially laid out in #8548 is minimally solved by #8889, but there is more to be done. This also builds on #8668 which added

Screen Shot 2020-01-17 at 9 58 23 AM

Let's add a link to this commit warning so the user can enter the create a fork flow in #8889.

Text should read:

You don't have write access to {RepoName}. Want to make a fork?

/cc @ampinsk @billygriffin
@outofambit outofambit self-assigned this Jan 17, 2020
@outofambit outofambit added this to Backlog (unprioritized) in Desktop 2.3 release via automation Jan 17, 2020
@outofambit outofambit moved this from Backlog (unprioritized) to In Progress Issues in Desktop 2.3 release Jan 17, 2020
@outofambit outofambit mentioned this issue Jan 17, 2020
Merged
@tierninho tierninho assigned tierninho and unassigned tierninho Jan 17, 2020
@outofambit outofambit linked a pull request Jan 17, 2020 that will close this issue
[Fork] Add create fork flow entry point to commit warning #8939
Merged
@tierninho
Copy link
Contributor

LGTM! 🚢

Desktop 2.3 release automation moved this from In Progress Issues to Done! Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@outofambit outofambit

Labels
epic:fork
Projects
No open projects
Desktop 2.3 release
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fork] Add create fork flow entry point to commit warning desktop/desktop
4 participants
@outofambit @tierninho and others