Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Both the Desktop Search and Code Mirror Default Search Show #9563

Closed
say25 opened this issue Apr 19, 2020 · 0 comments · Fixed by #10141
Closed

Both the Desktop Search and Code Mirror Default Search Show #9563

say25 opened this issue Apr 19, 2020 · 0 comments · Fixed by #10141
Labels
bug Confirmed bugs or reports that are very likely to be bugs codemirror Issues related to our use of CodeMirror that may require upstream fixes

Comments

@say25
Copy link
Member

say25 commented Apr 19, 2020 •
edited

Describe the bug

Both the Desktop Search and Code Mirror Default Search show in app.

Version & OS

2.4.2-beta1, macOS 10.14.6

Steps to reproduce the behavior

  1. Go to changed files tab.
  2. Hit CmdOrControl+F three times in a row
  3. See both the Desktop and Code Mirror Default Search

Screenshots

GitHubSearch

Additional context

Should we have our own custom search box at all? Maybe we should just use the built in search.
@say25 say25 added bug Confirmed bugs or reports that are very likely to be bugs codemirror Issues related to our use of CodeMirror that may require upstream fixes labels Apr 19, 2020
@niik niik mentioned this issue Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs codemirror Issues related to our use of CodeMirror that may require upstream fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reuse existing search dialogs in text diffs desktop/desktop
2 participants
@say25 and others