Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL2 repos should open in VSCode Remote #9721

Open
pluma opened this issue May 7, 2020 · 5 comments
Open

WSL2 repos should open in VSCode Remote #9721

pluma opened this issue May 7, 2020 · 5 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs enhancement integrations Issues related to editor and shell integrations that ship in Desktop windows Issues specific Desktop usage on Windows

Comments

@pluma
Copy link

pluma commented May 7, 2020

Describe the feature or problem you’d like to solve

When working with a repository from a WSL2 path (\\wsl$\<distro name>\<path>), launching VSCode will simply open the path as if it were a regular network path. As users using VSCode with WSL will most likely be using the Remote extension, this makes the "launch VSCode" button practically useless.

Proposed solution

GitHub Desktop should recognize that a repository path is a WSL2 path and offer to launch VSCode from within WSL rather than from Windows.

Additional context

This feature request was prompted by my question at Satellite 2020: https://github.com/githubevents/satellite2020/discussions/8#discussioncomment-10795

@outofambit
Copy link
Contributor

Thanks for writing this up @pluma! Will be sure to take a look at this when we spend more time on WSL(2).

@outofambit outofambit added bug Confirmed bugs or reports that are very likely to be bugs enhancement integrations Issues related to editor and shell integrations that ship in Desktop windows Issues specific Desktop usage on Windows labels May 8, 2020
@just1a-person
Copy link

TL;DR

Contents of VS Code AppData bin folder

code.cmd gets run when you invoke code from cmd or powershell

code is a shell script that runs when you invoke code in WSL

@AlexStormwood
Copy link

AlexStormwood commented Jan 15, 2023

This is the first Google search result when I search for "github desktop open vscode in wsl". It would be a hugely appreciated feature to simplify my dev workflow and surely the workflow for any other WSL-based developers.

@beingmerry
Copy link

beingmerry commented Feb 3, 2023

Bumping this. GitHub desktop would be much more useful if I didn't have to do 2 clicks (1 to open, 1 to switch to WSL extension) when launching VS Code.

This should be a configuration change of changing the shell calling the commands. This looks possible and the intent under the Options > Integrations tab (see below) looks promising with drop-downs for External Editor and Shell, however; once changed to VS Code and WSL, VS Code still does not launch with WSL remoted in.

image

As an aside and to my surprise: searching WSL on GitHub docs returns nothing.

image

@beingmerry
Copy link

@outofambit hi! do you still work on the terminal team? Just wondering if this issue is on the radar. I think it would just involve piping the command through the Ubuntu terminal vs Cmd.exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs enhancement integrations Issues related to editor and shell integrations that ship in Desktop windows Issues specific Desktop usage on Windows
Projects
Development

No branches or pull requests

7 participants
@outofambit @pluma @beingmerry @AlexStormwood @just1a-person and others