Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Electron 7 #170

Closed
ottosson opened this issue Oct 24, 2019 · 5 comments
Closed

Add support for Electron 7 #170

ottosson opened this issue Oct 24, 2019 · 5 comments

Comments

@ottosson
Copy link
Contributor

ottosson commented Oct 24, 2019

https://github.com/electron/electron/releases/tag/v7.0.0

I don't have a clue what's needed to make registry-js work with Electron 7, but just looking at #164 it looks like it is as simple as just adding -t 7.0.0 to prebuild-electron and prebuild-electron-ia32 and update the node-abi dependency?

Is there something else that's needed?

@shiftkey
Copy link
Member

Is there something else that's needed?

Nope, that's it.

We may need also to bump node-abi as I can see electron/node-abi@efa7539 has been published. That will ensure prebuild and prebuild-install can detect Electron 7.

@shiftkey
Copy link
Member

This is now available in v1.9.0 on NPM.

@ottosson
Copy link
Contributor Author

I get an error when trying to run my project using Electron 7:

Error: Could not detect abi for version 7.0.0 and runtime electron. Updating "node-abi" might help solve this issue if it is a new release of electron

I have made sure the latest version of node-abi is installed in my node_modules.

@shiftkey
Copy link
Member

@ottosson this really feels like #166 again and prebuild-install not finding the latest version.

@ottosson
Copy link
Contributor Author

There were some issue with electron-rebuild. I know it's not necessary (from the warnings) but for some reason I needed it a while back for registry-js to build (don't know why 😑) and I've left it in the project since. Removing it seems to solve the issue.

Moving on! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants