New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Electron 7 #170
Comments
Nope, that's it. We may need also to bump |
This is now available in |
I get an error when trying to run my project using Electron 7:
I have made sure the latest version of node-abi is installed in my node_modules. |
There were some issue with electron-rebuild. I know it's not necessary (from the warnings) but for some reason I needed it a while back for registry-js to build (don't know why 😑) and I've left it in the project since. Removing it seems to solve the issue. Moving on! 😊 |
https://github.com/electron/electron/releases/tag/v7.0.0
I don't have a clue what's needed to make registry-js work with Electron 7, but just looking at #164 it looks like it is as simple as just adding
-t 7.0.0
toprebuild-electron
andprebuild-electron-ia32
and update thenode-abi
dependency?Is there something else that's needed?
The text was updated successfully, but these errors were encountered: