Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement media tagging #118

Closed
RiccardoM opened this issue Mar 12, 2020 · 1 comment · Fixed by #153
Closed

Implement media tagging #118

RiccardoM opened this issue Mar 12, 2020 · 1 comment · Fixed by #153
Assignees
Labels
kind/new-feature Propose the addition of a new feature that does not yet exist x/posts Post module
Projects
Milestone

Comments

@RiccardoM
Copy link
Contributor

Feature description

Currently, when creating a media the user can specified it's URI and MimeType. In order to better support media sharing (particularly images) on a wide range of social networks, we should implement media tagging. Thanks to this features, users will be able to tag other users on a particular image to make sure they are someone recognizes when that image is viewed.

Implementation proposal

In order to implement media tagging, the following changes should be made.

Update he PostMedia type

First of all, we need to update the PostMedia type to be:

type PostMedia struct {
	URI      string           `json:"uri"`
	MimeType string           `json:"mime_type"`
        Tags     []sdk.AccAddress `json:"tags"`     // Contains the list of all the tagged users
}

Update the CLI and REST commands

Then we need to update the CLI and REST commands to allow tagging. The most particular one will be the CLI one. I think the --media flag can be changed to something like:

--media "<URI>,<MimeType>,<Tags...>

So an example could be

--media "https://example.com,image/jpeg,desmos1p7c8h59nrc8e5hxvgvu2g7tpp0xwn4mzevzgg7,desmos1p7ad878nealg249qkkdl9ldxrllst23lklngcx

What are your thoughts on this @bragaz @kwunyeung?

@RiccardoM RiccardoM added x/posts Post module kind/new-feature Propose the addition of a new feature that does not yet exist labels Mar 12, 2020
@RiccardoM RiccardoM added this to the v0.5.0 milestone Mar 12, 2020
@RiccardoM RiccardoM added this to To do in Desmos via automation Mar 12, 2020
@RiccardoM RiccardoM removed this from the v0.5.0 milestone Apr 25, 2020
@leobragaz
Copy link
Contributor

I could go with this one, what do you think? @RiccardoM

@RiccardoM RiccardoM added this to the v0.6.0 milestone May 6, 2020
Desmos automation moved this from To do to Done May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/new-feature Propose the addition of a new feature that does not yet exist x/posts Post module
Projects
No open projects
Desmos
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants