Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for empty message posts if the poll is specified #148

Closed
RiccardoM opened this issue May 1, 2020 · 0 comments · Fixed by #149
Closed

Allow for empty message posts if the poll is specified #148

RiccardoM opened this issue May 1, 2020 · 0 comments · Fixed by #149
Assignees
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add
Projects
Milestone

Comments

@RiccardoM
Copy link
Contributor

Context

Currently the user cannot create an empty message post which contains a message, because the message is marked optional only if the medias are not empty.

We should definitely allow the creation of empty messages posts if they contain a poll.

Solution

In order to allow this, we should reduce the tx posts create command required arguments from 2 to 1, making the message optional.

Then we need to check in both the ValidateBasic method of MsgCreatePost and Validate of Post if the post has either a message, a poll or at least a media to be valid.

@RiccardoM RiccardoM added kind/enhancement Enhance an already existing feature; no "New feature" to add UX:Improvements labels May 1, 2020
@RiccardoM RiccardoM added this to To do in Desmos via automation May 1, 2020
@leobragaz leobragaz self-assigned this May 4, 2020
Desmos automation moved this from To do to Done May 6, 2020
@RiccardoM RiccardoM added this to the v0.5.0 milestone May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add
Projects
No open projects
Desmos
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants