Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiles moniker flag take full-node moniker as default value #413

Closed
leobragaz opened this issue May 4, 2021 · 5 comments · Fixed by #415
Closed

Profiles moniker flag take full-node moniker as default value #413

leobragaz opened this issue May 4, 2021 · 5 comments · Fixed by #415
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@leobragaz
Copy link
Contributor

Bug description

If we try to save a profile with the desmos tx profiles save transaction, without specifying the --moniker flag, the module will not use its default [do-not-modify] one. Instead, he will use the moniker of the full node.

Steps to reproduce

desmos tx profiles save <dtag>...
check the tx info before sending it.

Expected behavior

It should take the default flag and not the full node moniker.

@leobragaz leobragaz added the kind/bug Something isn't working label May 4, 2021
@leobragaz leobragaz assigned RiccardoM and unassigned RiccardoM May 4, 2021
@leobragaz
Copy link
Contributor Author

I've tried to solve it locally by replacing moniker flag name with monikerz and it worked.
Any thoughts on this? @RiccardoM

@RiccardoM
Copy link
Contributor

@bragaz I think that probably what we should do in this case is renaming the Moniker field to Username all together. This should clear up a lot of things and make it easier for users to understand what is it. Would also like to know @kwunyeung's opinion

@leobragaz leobragaz self-assigned this May 5, 2021
@leobragaz leobragaz mentioned this issue May 5, 2021
7 tasks
@kwunyeung
Copy link
Contributor

@bragaz @RiccardoM If we have to change this, I prefer avoiding naming it username as it may create confusion. I prefer calling it nickname, pen-name, stage-name.

@RiccardoM
Copy link
Contributor

@bragaz @RiccardoM If we have to change this, I prefer avoiding naming it username as it may create confusion. I prefer calling it nickname, pen-name, stage-name.

nickname would be perfect IMO. We can go for that

@leobragaz
Copy link
Contributor Author

Then nickname be 🚀

@RiccardoM RiccardoM added this to the v0.16.2 milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants