Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The created time of a post should be in time but not height #62

Closed
kwunyeung opened this issue Dec 31, 2019 · 0 comments · Fixed by #71
Closed

The created time of a post should be in time but not height #62

kwunyeung opened this issue Dec 31, 2019 · 0 comments · Fixed by #71
Assignees
@RiccardoM
Labels
x/posts Post module
Projects
Desmos
Milestone
v0.2.0

Comments

@kwunyeung
Copy link
Contributor

kwunyeung commented Dec 31, 2019 •
edited

Oh suddenly I found that I was wrong. I thought it would be cool to have the block height as time reference but the block time won't be available if the blocks will be clear out in chain upgrade. Should revert it back to timestamp so that we can get it directly from the chain state. My bad.
@RiccardoM RiccardoM added the x/posts Post module label Jan 7, 2020
@RiccardoM RiccardoM added this to To do in Desmos via automation Jan 7, 2020
@RiccardoM RiccardoM added this to the v0.2.0 milestone Jan 7, 2020
@RiccardoM RiccardoM self-assigned this Jan 8, 2020
@RiccardoM RiccardoM mentioned this issue Jan 8, 2020
Merged
6 tasks
Desmos automation moved this from To do to Done Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RiccardoM RiccardoM

Labels
x/posts Post module
Projects
No open projects
Desmos
  
Done
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Replaced block height with timestamps desmos-labs/desmos
2 participants
@kwunyeung @RiccardoM