Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stretched display mode #640

Closed
2 of 3 tasks
Evengard opened this issue Feb 2, 2024 · 12 comments
Closed
2 of 3 tasks

Stretched display mode #640

Evengard opened this issue Feb 2, 2024 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@Evengard
Copy link

Evengard commented Feb 2, 2024

  • Did you check to see if this issue already exists?
  • Is this only a single feature request? Do not put multiple feature requests in one issue.
  • Is this a question or discussion? Don't use this, use https://lemmy.ml/c/thumbkey

Describe the feature request below

Hello! There is 3 position modes: centered, left or right. I'm coming from MessagEase, and I'm actually using the "stretched" mode. Is it possible to implement it here as well?

Thanks!

@Evengard Evengard added the enhancement New feature or request label Feb 2, 2024
@Evengard Evengard changed the title Stretch Stretched display mode Feb 2, 2024
@asdkant
Copy link
Contributor

asdkant commented Feb 4, 2024

What would "stretched" mode be?

@Evengard
Copy link
Author

Evengard commented Feb 4, 2024

Screenshot_2024-02-04-11-12-22-80_984e1414ae90666a90f12ff17ec14a7f

That's how it is in the rival MessagEase

@dessalines
Copy link
Owner

Dupe of #399

@dessalines dessalines closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2024
@Evengard
Copy link
Author

Evengard commented Feb 4, 2024

That's unfortunate. I'm really used to this stretched layout, and I think a lot of people too... Is there any reasoning behind WHY not planned to do a setting to make them not perfectly square?

@dessalines
Copy link
Owner

Fluid layouts are more complicated (which keys are allowed to stretch and which aren't, where do they stretch?), or if you wanted to add h/w ratios for each key, it'd be much more complicated. If you do a PR for this tho I wouldn't be opposed, but it'd be a lot of work.

@Evengard
Copy link
Author

Evengard commented Feb 4, 2024

I am actually considering working on some PRs, so I want just to make sure we're on the same page.

In MessagEase in stretched mode actually all keys are stretched uniformely, without any regard to which key it is. I considered taking the same approach for that setting here. Do you think it is acceptable, or you have something different in mind?

@dessalines
Copy link
Owner

Sure, that'd be fine. A boolean default off for fill_width

@Kommynct
Copy link
Contributor

Kommynct commented Feb 5, 2024

It should also disable the button to move the keyboard to center/left/right if this is enabled.

@Evengard
Copy link
Author

Evengard commented Feb 5, 2024

Well that's debatable. I was actually thinking more along the lines of actually making it one of the settings (left, right, centered, stretched [add]). So that button would cycle through 4 of them instead of 3 current.

@Zwyx
Copy link
Contributor

Zwyx commented Feb 5, 2024

Would also be super keen to have a stretch mode 👍 (Or the ability to change the keys' ratio to have them rectangular.)

@Zwyx
Copy link
Contributor

Zwyx commented Feb 8, 2024

I was interested in tinkering with the code, but didn't mention it here because I wasn't sure what would I be able to do (I never used Kotlin before and my experience with Android dev is limited).

Turns out, the code base is very easy to understand 🙂

So I've got something working:

wide-keyboard

I made a draft PR here to discuss the solution.

@dessalines
Copy link
Owner

Closed by the above PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants