Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"@" character doesn't work on spanish MessagEase layout alphabetic layers #759

Closed
6 of 7 tasks
asdkant opened this issue Feb 22, 2024 · 5 comments · Fixed by #762
Closed
6 of 7 tasks

"@" character doesn't work on spanish MessagEase layout alphabetic layers #759

asdkant opened this issue Feb 22, 2024 · 5 comments · Fixed by #762
Labels
bug Something isn't working

Comments

@asdkant
Copy link
Contributor

asdkant commented Feb 22, 2024

Steps to reproduce

  1. (configure and) switch to "español messagease"
  2. try to type @ character (bottom-left swipe from "R") on lower or upper case alphabetic layers

Expected behavior

@ is detected

Actual behavior

Either nothing is detected, or the tap symbol (R or r) is detected. The symbol on the numeric layer works fine.

version of the program

2.6.18

Android version

14 (OneUI 6.0)

Device

Samsung Galaxy S21 FE

Other details

This looks like thumb-key is not parsing the layer definition correctly. I checked the code and the layout definition seems correct:

Also tested and reproduced on:

  • v2.6.16 & v2.6.18 (Galaxy Tab S5e, androdid 11, OneUI 3.1)
  • v2.6.17 (same S21 FE)
  • v2.6.18 (Galaxy A52, android 13, OneUI 5.1 )

So it doesn't seem to be device-specific.

Acknowledgements

  • I have written a short but informative title.
  • I have updated the app to the latest version.
  • I have searched the existing issues and this is a new one, NOT a duplicate or related to another open issue.
  • This is not a question or a discussion, in which case I should have gone to lemmy.ml/c/thumbkey
  • This is a single bug report, in case of multiple bugs I will open a separate issue for each one (they can always link to each other if related)
  • I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements. 🤡
  • I have filled out all of the requested information in this form.
@asdkant asdkant added the bug Something isn't working label Feb 22, 2024
@dessalines
Copy link
Owner

Probably has to do with an incorrect swipetype.

@asdkant
Copy link
Contributor Author

asdkant commented Feb 22, 2024

You mean the SwipeDirection.BOTTOM_LEFT thing? But that's correct:

// lower case
SwipeDirection.BOTTOM_LEFT to
    KeyC(
        display = KeyDisplay.TextDisplay("@"),
        action = KeyAction.CommitText("@"),
        color = ColorVariant.MUTED,
    ),
// upper case
SwipeDirection.BOTTOM_LEFT to
    KeyC(
        display = KeyDisplay.TextDisplay("@"),
        action = KeyAction.CommitText("@"),
        color = ColorVariant.MUTED,
    ),
// numeric
SwipeDirection.BOTTOM_LEFT to 
    KeyC(
        display = KeyDisplay.TextDisplay("@"), 
        action = KeyAction.CommitText("@")
    ),

@asdkant
Copy link
Contributor Author

asdkant commented Feb 22, 2024

How can I properly debug this issue?

@dessalines
Copy link
Owner

This is incorrect, it needs to be fixed by removing that line (so it uses the default all swipe directions) https://github.com/dessalines/thumb-key/blob/main/app/src/main/java/com/dessalines/thumbkey/keyboards/ESMessageEase.kt#L206

@asdkant
Copy link
Contributor Author

asdkant commented Feb 23, 2024

Ohh, ok, I get it now. I'm working on some changes to this keybard (a rework on the placement of ¿ and ¡ mostly, I've been test driving it for a few days) so I'll include it there and do the PR later today if nobody fixes it before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants