Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FSharp 5.0 #25

Closed
AlexeyRaga opened this issue Jun 2, 2021 · 2 comments · Fixed by #26
Closed

Add support for FSharp 5.0 #25

AlexeyRaga opened this issue Jun 2, 2021 · 2 comments · Fixed by #26

Comments

@AlexeyRaga
Copy link

I am having this warning when using C# 5.0:

 warning NU1608: Detected package version outside of dependency constraint: Destructurama.FSharp 1.1.0 requires FSharp.Core (>= 4.6.2 && < 4.7.0) but version FSharp.Core 5.0.0 was resolved

But everything seems to be working fine.

Can the upper bound constraint be bumped?
@nblumhardt
Copy link
Contributor

Sounds good to me 👍 - help welcome if anyone can take a look.

@AlexeyRaga
Copy link
Author

AlexeyRaga commented Jun 2, 2021 •
edited
Loading

I looked at it briefly, but I am a Haskell dev, not really an F# dev.. And I wasn't able to figure out where that upper bound is coming from, it isn't specified anywhere (that I can see) explicitly.

Perhaps someone who has better knowledge about it can take a look...

@FlippievanDyk FlippievanDyk mentioned this issue Jul 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes FSharp.Core Upper bound FlippievanDyk/fsharp
2 participants
@nblumhardt @AlexeyRaga