You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using Built-in Exceptions would be ideal than writing custom Exceptions. Simple solution would be to use the built-in KeyErrorException. Refactoring the codebase with Custom Exceptions might make it harder for the maintainers, who have their own flow -- just something to think about before creating a PR.
In a few places in
deta/base.py
exceptions are raised with theException
class.See https://github.com/deta/deta-python/blob/5e68173ffea4b3dd2c3d75fadda4e3c9854d3199/deta/base.py.
deta-python/deta/base.py
Line 134 in 5e68173
deta-python/deta/base.py
Line 272 in 5e68173
It'd be better practice if custom exceptions were defined and derived from the general
Exception
class.The text was updated successfully, but these errors were encountered: