Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: baseline file input with mask #109

Open
avegrv opened this issue Jan 12, 2021 · 3 comments
Open

Feature request: baseline file input with mask #109

avegrv opened this issue Jan 12, 2021 · 3 comments
Labels
feature New feature or request

Comments

@avegrv
Copy link

avegrv commented Jan 12, 2021

I have an android project with multiple modules and separate baseline files in each module. I want to have the ability to input the baseline file location like a mask at the plugin settings page.

@chao2zhang chao2zhang added the feature New feature or request label Jan 25, 2021
@chao2zhang
Copy link
Member

I believe this is super useful, but I would also imagine this requires a decent amount of work because this requires our plugin to understand the gradle script.

@Lafreakshow
Copy link

It may already be enough to use what information IntelliJ can provide. For example, the plugin could look for baseline files relative to module/project content root and maybe it's possible to implement some variable substitution so that the mask can include things like, for example, $module.contentRoot. I know some other plugins have similar features and IntelliJ makes use of this quite a bit in both config files and templates so maybe the IntelliJ Platform has a convenient API for this. You guys are probably better acquainted with the IntelliJ Platform and Android projects than I am so I may also be completely on the wrong path here...

Anyway, basis for this idea is that IntelliJ organises Gradle projects in modules and uses module relative paths for quite a bit of configuration already so it might not actually be necessary to touch Gradle buildscripts for this. It would be less convenient for the user than just taking the configuration directly from Gradle but it could achieve the goal quite decently.

Though... From my own experiences with developing IntelliJ plugins, I'm not sure which idea is less work...

@mamuf
Copy link

mamuf commented Apr 3, 2023

I'd like this feature as well. It's fairly common for me to have multiple Gradle builds in a single IJ project.

For example, when developing a library at the same time as some other piece of sw that uses it – that's where Gradle Composite builds come in and IJ has support for that, too, so it's only natural to have such builds in a single IJ project.

I'd be fine having to configure it manually on a per-module basis, but an automatically detected setup would be awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants