File paths should be platform-independent

[rock3r]

Config file paths (and possibly other paths such as baseline) are stored in detekt.xml and read back as platform-dependent.

This means that if the detekt.xml is shared in VCS for the whole team to use, and not everyone is on the same OS (mix of POSIX and Windows users) the paths will not work for some folks and they'll be bombarded by "file not found" notifications from the Detekt plugin.

The plugin should store paths in a platform-independent way and apply the correct separators at runtime.

[arturbosch]

Related #117 (comment)

Idea:
Use TableView instead of a single file chooser element in settings.
Save config paths as list.
Use a ToolbarDecorator provide add actions which trigger a file chooser dialog.

[rock3r]

I'm actually working on that. Hopefully will have a PR soon. Fighting a bit with IJ :)

[arturbosch]

I'm actually working on that. Hopefully will have a PR soon. Fighting a bit with IJ :)

Ah, cool! Good that I read your comment before starting it too :).

Just to be sure (if you thought about migrating to Kotlin UI DSL): the Kotlin UI DSL will need a minimum IJ version of 2022.1 and Android Studio does not yet support it afaik.
I have a branch with it 326bc9f

I also fight a bit with IJ and try to report broken tests with the IntelliJ Gradle plugin 1.8 :)

[rock3r]

I have tried maintaining the forms, but yeah, it wouldn't work. I'm migrating to the Kotlin DSL — it should mostly be ok, there's only one or two minor things in the DSL that weren't available (according to the inspections) before 22.1, but they can be emulated decently enough. So far, I am keeping 20.3 as the minimum target version, although tbh I think we can increase up to 21.2 if needed, which would still support AS stable (Chipmunk). I will only do it if needed, though.

My (very much WIP) work is here.

BTW on the topic of OS independence, I have asked and theoretically the only need we need to do is storing paths as POSIX, the IDE will take care of relativizing them (which currently only works on POSIX as we store paths on Windows as Windows paths which aren't supported properly, see #135).

[arturbosch]

I have tried maintaining the forms, but yeah, it wouldn't work. I'm migrating to the Kotlin DSL — it should mostly be ok, there's only one or two minor things in the DSL that weren't available (according to the inspections) before 22.1, but they can be emulated decently enough. So far, I am keeping 20.3 as the minimum target version, although tbh I think we can increase up to 21.2 if needed, which would still support AS stable (Chipmunk). I will only do it if needed, though.

Yes please, if you are sure about Android lets go with 21.2.
ui.dsl.builder should be version 2 of Kotlin UI DSL ? So it can't work with 20.3 right?

My (very much WIP) work is here.

BTW on the topic of OS independence, I have asked and theoretically the only need we need to do is storing paths as POSIX, the IDE will take care of relativizing them (which currently only works on POSIX as we store paths on Windows as Windows paths which aren't supported properly, see #135).

Looks good! If you open a WIP-PR I can write some comments if you like (treatAsWarnings = false).

I see you upgrade the intellij plugin. How did you solve #211 ?

[rock3r]

@arturbosch I have a couple of questions for you, I pinged you on the Kotlin Slack, but I am not sure you actually use it. Let me know if you prefer other ways to get in touch.