In Travis CI: "0 kotlin files were analyzed."

[3flex]

Expected Behavior

detekt Gradle plugin analyzes files during CI.

Current Behavior

detekt Gradle plugin does not analyze any files during CI.

Steps to Reproduce (for bugs)

View the Travis build log for master branch (https://travis-ci.org/arturbosch/detekt/jobs/432263468 at time of writing). See "0 kotlin files were analyzed." multiple times in the logs.

Context

N/A

Your Environment

N/A - build running in CI environment

[3flex]

On closer inspection, looks like this is on Travis only, not AppVeyor... may be a *nix vs Windows issue with detekt itself?

[Mauin]

Just to clarify: This does not just affect master builds but pretty much every build on travis it seems. I cannot repro this locally.

[3flex]

Simple when you know what to look for...

The filters set when Travis build runs includes .*/build/*.. Travis checks out the build at /home/travis/build/arturbosch/detekt. Since /build/ is in the full file path, all Kotlin files under the project path are filtered out, so nothing gets scanned.

I'd say the root cause is that though the detekt is run from working directory /home/travis/build/arturbosch/detekt, and expectation is that it's filtering based on the relative path in that working directory it's actually filtering the absolute file path.

[Mauin]

Oh. Right... You want to submit a fix for this?
Probably simply changing it to detekt/.*/build/.* or similar

[3flex]

Can do for Travis, yeah. But I'm also going to open a new issue to see if behaviour should change - I'm surprised that it's not just the relative path where the filter applies.

[Mauin]

True, that would be the overall better fix for it. Which makes me wonder. Did we change this behavior at some point? (absolute vs relative path considered for excluding paths)

Or did Travis change the directory projects get cloned into...?

[3flex]

I know there have been some recent changes to path filtering in detekt, so my guess is a change was made that inadvertently changed the behaviour.

Opened #1212 to track.

[Mauin]

Looking at PathFilter it seems that it did check the absolute path for quite some time.

[3flex]

Do you want to close this in favour of a proper fix for #1212, or implement a workaround?

I'm inclined to close this since root cause is identified and an issue opened to track the issue. AppVeyor appears to run detekt just fine as part of the build so any non-compliant code will still fail CI.

[Mauin]

👍 Thanks for opening the concrete issue. We should definitely fix this properly.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.