Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop FunctionMinLength & FunctionMaxLength #1290

Closed
vanniktech opened this issue Oct 26, 2018 · 5 comments
Closed

Drop FunctionMinLength & FunctionMaxLength #1290

vanniktech opened this issue Oct 26, 2018 · 5 comments
Labels
Milestone

Comments

@vanniktech
Copy link
Contributor

Looking at the inspections of IntelliJ it seems like it does not validate against min/max length. Glancing over the conventions / style guides I also could not find any restrictions.

@schalkms
Copy link
Member

I don't think that this is good idea. I for one use this rule quite frequently.
In my opinion such a reasonable guideline for function naming makes sense.

As previously said, we should let the user decide. There's always the option in detekt to disable this rule, if you have no need for it.

@vanniktech
Copy link
Contributor Author

FunctionMaxLength I might agree.

With FunctionMinLength it's hard. Often you have functions like id which are flagged. Same for logging verbosity such as d, i, e, w which also get flagged.

@vanniktech
Copy link
Contributor Author

Another one is io

@arturbosch
Copy link
Member

As @schalkms said its a good thing that detekt is highly configurable and the user is free to set his defaults as he wants. These rules are also off by default.

@arturbosch arturbosch added this to the RC10 milestone Nov 2, 2018
@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants