Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about removing the issue weights feature for build failure thresholds #2272

Closed
arturbosch opened this issue Jan 19, 2020 · 4 comments
Closed

Comments

@arturbosch
Copy link
Member

arturbosch commented Jan 19, 2020

Further discussion from #2266

Expected Behavior

Remove the extra complexity.

Current Behavior

Issue kinds can be weighted to influence the build failure threshold higher than other issues.
Do we want to maintain this feature?
The only usecase I see is to have specific rules printed on the console as a reminder to remove them someday.

Context

#2266

@schalkms
Copy link
Member

I think we shouldn’t remove this. We also have a similar unresolved feature in #533.

@Mkohm
Copy link
Contributor

Mkohm commented Jan 30, 2020

I am using this feature!

I am developing an extension to detekt that focuses on detection of programming principle violations. Because these principles are hard to detect with low false-positive rate i need a way of spotting them, but without breaking the build and creating unnecessary noise.

@schalkms
Copy link
Member

Nice project @Mkohm
I gave it star. It looks really promising.
It’s always great to see such efforts!!

@schalkms
Copy link
Member

Closed because I think this really provides value to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants