-
-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow boolean function reference properties for NonBooleanPropertyPrefixedWithIs
#4675
Comments
This sounds like a valid edge case to add to the rule 🤔 or maybe worth a local suppress. I'm not sure how fine grained the rule should behave (like understand if the functional type is returning |
I use these a lot and I try to suppress as little as possible. With type resolution, would the type of the reference be available? If so would it be simple to check if it is a function reference, and then check the return type parameter? |
#4684 fixed this |
Should this be extended to also allow |
🤔 I don't think so. That seems like a edge case to me. |
Since
is
prefix is used for functions that return a boolean, I think it would make sense to allow function references that return a boolean to be prefixed withis
:The text was updated successfully, but these errors were encountered: