Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DGP off Sarif4k #5864

Closed
cortinico opened this issue Feb 28, 2023 · 5 comments · Fixed by #6117
Closed

Refactor DGP off Sarif4k #5864

cortinico opened this issue Feb 28, 2023 · 5 comments · Fixed by #6117

Comments

@cortinico
Copy link
Member

Is the remaining action that we should refactor DGP off Sarif4k so that

  • Respecting KGP compileOnly dependency
  • Not exposing transitive dependency when our client/users depends on KGP

Originally posted by @chao2zhang in detekt/sarif4k#43 (comment)

@chao2zhang
Copy link
Member

There are two ways I can think of

  • Depend on simplejson to do lightweight parsing and merging
  • Because gradle bundles with GSON or Jackson, we can define the object mapping for Sarif in Gson or Jackson.

@cortinico
Copy link
Member Author

Because gradle bundles with GSON or Jackson, we can define the object mapping for Sarif in Gson or Jackson.

I would prefer this one as it won't bring any extra dependency

@TWiStErRob
Copy link
Member

TWiStErRob commented May 19, 2023

Would package relocation be an option that might be simpler to achieve without a rewrite of I/O in Detekt?

@cortinico
Copy link
Member Author

Yup that's also an option. Still we use just one method of Sarif4k in DGP, so refactoring might be preferred

@TWiStErRob
Copy link
Member

I was curious how it would look like, so I raised #6117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants