Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetektCli depends on kotlin-compiler-embeddable which pulls in older version of json-org-java #596

Closed
faizanahemad opened this issue Dec 7, 2017 · 2 comments
Labels
Milestone

Comments

@faizanahemad
Copy link

While using DetektCli with our build tool, we also pull in kotlin-compiler-embeddable, whose fatjar has older versions of classes like JSONArray which are incompatible with versions > 2.0
The class I am speaking of is in org.json package named JSONArray.

Is it possible to get rid of kotlin-compiler-embeddable dependency and rather depend on Kotlin and Kotlin reflect?

@arturbosch
Copy link
Member

Unfortunately not. Detekt depends in the kotlin compiler for ast traversal. I'm wondering why the embeddable jar causes you problems .... It shadows everything so there are no conflicts with your code ...

Do you use gradle?

@arturbosch arturbosch added this to the RC6 milestone Dec 20, 2017
@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants