Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnnecessaryInnerClass Rule #875

Closed
vanniktech opened this issue Apr 22, 2018 · 2 comments
Closed

UnnecessaryInnerClass Rule #875

vanniktech opened this issue Apr 22, 2018 · 2 comments
Labels
feature help wanted rules

Comments

@vanniktech
Copy link
Contributor

Sometimes nested classes are declared as inner although they should not. In that case the fix is trivial - removing the inner keyword. It would be nice if there's a rule for this.

There's a high risk for false positives though so it should be tested thoroughly on sample projects.
@schalkms
Copy link
Member

Good idea!

@severn-everett severn-everett mentioned this issue Dec 23, 2021
Merged
@BraisGabin
Copy link
Member

This is already implmented in 1.20 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature help wanted rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BraisGabin @vanniktech @schalkms