Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Detekt on Detekt #212

Closed
vanniktech opened this issue Jul 13, 2017 · 7 comments
Closed

Run Detekt on Detekt #212

vanniktech opened this issue Jul 13, 2017 · 7 comments
Assignees
@arturbosch
Labels
build improvement
Milestone
M13.2

Comments

@vanniktech
Copy link
Contributor

So also the Detekt Code gets checked by Detekt.
@arturbosch
Copy link
Member

What do you mean? detekt has the detekt gradle plugin imorted and detektCheck is run in CI ...

@vanniktech
Copy link
Contributor Author

Then how come the MaxLine rule doesn't complain on my previous PR?

@arturbosch
Copy link
Member

Because of this line usedDetektGradlePlugin=1.0.0.M12.1 :D, need upgrade to M13 ^^

@arturbosch
Copy link
Member

Also I think with the baseline we should have 0 code smells. Lets turn the threshold to 1 then ^^

@vanniktech
Copy link
Contributor Author

Also might be an option to use the failFast flag.

@arturbosch
Copy link
Member

Will try it out!

@arturbosch arturbosch self-assigned this Jul 13, 2017
@vanniktech vanniktech mentioned this issue Jul 17, 2017
Merged
@arturbosch arturbosch added this to the M13.2 milestone Jul 22, 2017
@lock
Copy link

lock bot commented Jun 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@arturbosch arturbosch

Labels
build improvement
Projects
None yet
Milestone
M13.2
Development

No branches or pull requests
2 participants
@vanniktech @arturbosch