Imported division from __future__ for Python 2 compatibility #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out fixing this for Python 2 was very simple. The only issue was that in Python 2, the behaviour of the division operator
/
changes to integer division when both operands are integers. This pull request just addsfrom __future__ import division
to all files to change this to the Python 3 behaviour (division is always float division). This does not need to be in a separate branch of the package, as this statement does nothing in Python 3, so the same codebase works both in Python 2 and 3.