Various improvements.

[alxndrsn]

Hi, here's a modified pull request with the two methods indicated.

Commands implemented here:

GET /session/:id/source
DELETE /session/:id/cookie
GET /session/:id/element/:id/displayed

[detro]

Hi.
If you keep committing it will be hard to figure out what is covered by this pull request.

[alxndrsn]

Sorry, didn't realise pull requests change as more commits happen.

[detro]

you want to enter "and other authors" right?

[alxndrsn]

If it's appropriate.

[alxndrsn]

Where are the scripts in src/third_party/webdriver-atoms/ from? It's not clear from them how to map a WebDriver id back to an element in the DOM - is there an easy way to do this?

[detro]

The scripts are imported directly from the Selenium repo. I think you need to have that locally if you want to understand what the atoms do: without is pretty much impossible.

The method "toJson" in the WebElementRH returns the format that those script know how to convert from a WebElementID to an actual DOM element.

Unfortunately my understanding is based on conversations on the #selenium IRC channel, nothing more: doc is lacky there.

[alxndrsn]

Ah nice, thanks for the pointer.

[detro]

Ah, and it's all done via the bash script "magic" that it's in tools, if you want to understand exactly "HOW" I do it.

[alxndrsn]

I've implemented /name and /attribute/ as well - worked out how to get WebDriver HTMLElements inside execute_script, which is nice. Let me know when is convenient and I can merge these to my master branch and submit a pull request.

By the way, I'm using Geb to write end-to-end tests for this stuff. It's a bit of a Frankenstein project, but if you're interested then it's at https://github.com/alxndrsn/webdriver-geb-tests

[detro]

I'll merge and rename the "responseBasedOnResult", as it's should probably be something like ".successBasedOnResult".

Also, I think I'll have to add the Cookie manipulation Atoms and use those: they will make our life WAY easier.

Everything else looks good.

[detro]

Ah, btw, looking forward to your next pull request.

But make sure you catch up with code first: by than I might have finished with the changes I mentioned above.