Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isNoop is not thread safe #266

Open
wangbj opened this issue Feb 28, 2020 · 0 comments
Open

isNoop is not thread safe #266

wangbj opened this issue Feb 28, 2020 · 0 comments

Comments

@wangbj
Copy link
Collaborator

wangbj commented Feb 28, 2020

https://github.com/upenn-acg/detTrace/blob/13a37abf2b0babfe6d85f71defeb45f62adf41f6/src/rnr_loader.cpp#L90

Each threads can do syscalls in parallel, isNoop could have been overwritten by another thread if current thread is de-scheduled. It's better keep the rnr prehook/posthook simpler, by moving those noop checking into the actual rnr tool if they're really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant