Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] A disconnected coach still counted as coach #136

Closed
tcsabina opened this issue Feb 11, 2021 · 3 comments
Closed

[BUG] A disconnected coach still counted as coach #136

tcsabina opened this issue Feb 11, 2021 · 3 comments
Labels
bug coach

Comments

@tcsabina
Copy link
Collaborator

tcsabina commented Feb 11, 2021 •
edited

Based on [DP]BLooD_DoG's report:

Two people were voted in as coach and then one of them reconnected before match started. I think the server still counted 2 coaches as present and didn't let the one who reconnected try to /coach again. We had to switch maps and switch back to 'reset' the coach counter.
@tcsabina tcsabina added the bug label Feb 11, 2021
@tcsabina
Copy link
Collaborator Author

@deurk , can you label this with 'Coach'?

@deurk deurk added the coach label Feb 11, 2021
@tcsabina tcsabina changed the title [BUG] Coach cannot reconnect before match starts [BUG] A disconnected coach still counted as coach Mar 11, 2021
@tcsabina
Copy link
Collaborator Author

@deurk,
This is solved with PR #141. Please merge.

Thanks,
Toma

deurk pushed a commit that referenced this issue Mar 11, 2021
@tcsabina @deurk
Fixing #136: A disconnected coach still counted as coach
530d168
@tcsabina
Copy link
Collaborator Author

Available from KTX V1.40

ciscon pushed a commit to ciscon/ktx that referenced this issue Mar 19, 2021
@tcsabina @ciscon
Fixing QW-Group#136: A disconnected coach still counted as coach
7b59653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug coach
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deurk @tcsabina