Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL of update.py in one place ? #21

Closed
miroi opened this issue Jun 28, 2015 · 1 comment
Closed

URL of update.py in one place ? #21

miroi opened this issue Jun 28, 2015 · 1 comment

Comments

@miroi
Copy link
Contributor

miroi commented Jun 28, 2015

Greetings,

the URL for downloading the update.py , https://github.com/scisoft/autocmake/raw/master/update.py , are at four different places in autocmake:

  • update.py
  • test/test.py
  • test/fc/cmake/autocmake.cfg
  • test/cxx/cmake/autocmake.cfg

All these URLs have to be modified in when switching to autocmake forks, for example to https://github.com/miroi/autocmake/raw/master/update.py .

Could we have only one place in the code with this important URL ? The best solution would be separate file (I don't know if it would work for autocmake.cfg).

@bast
Copy link
Member

bast commented Jun 28, 2015

I agree that the current testing is annoying. I will change it such that it only
tests local files and will not fetch anything from the web. The current solution
is against "test first, push then".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants