-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The example on the README doesn't work #33
Comments
@wardellbagby Any thoughts on this? Referencing this https://docs.github.com/en/actions/security-guides/automatic-token-authentication and specifically Do we simply update the README to use the old style var since it references v0.2.1 and that is our current release? Then also maybe in the README we give a 2nd example for non-production testing of v1.0 pre-release? BTW, you did well in documenting this in the code: delete-tag-and-release/index.ts Lines 203 to 210 in 7550ea1
|
First, let's do some investigation. There's one question I'd like to know the answer to.
If it displays the README from the selected tag (and so changes as you use the version switcher), then we need to update the README to point to 1.0 and mention that it's a pre-release as well. If it doesn't, then we need to update the README like you suggested to have both versions of usage. |
on the marketplace... the default shows the v1.0 pre-release and it's longer README and using the version switcher with green button dropdown... get's this URL GitHub Action: Delete tag and releaseAdd following step to your workflow:
using the version switcher with green button dropdown... and switching to v1.0 get's this URL and the new README from v1.0 which is much longer GitHub Action: Delete tag and releaseUsage
|
Oh okay, that's perfect. Then we can just update the README to exclusive reference the 1.0 usage; that is to say, the usage where we pass the token as an input instead of an ENV var. Which means the only change needed is to change the version listed on the README to point to 1.0! I can do that but I likely won't get to it until tomorrow or Sunday, so feel free to do the update yourself if you'd like. |
@wardellbagby any updates? :-) yes, I'm asking nicely. Looks good enough? PR #35 |
@thadguidry It looks like we either need to update the 1.0 tag to point the latest commit on master or create a new 1.0.1 pre-release to get the GitHub Marketplace page to pull the correct README. Since this is just a documentation change, it's a good candidate for just updating the 1.0 tag but creating a new 1.0.1 is a bit easier and safer. Either/or, once that's done, we can close this issue. |
OK, I've created a new 1.0.1 pre-release. Does that seem to fix things? |
@thadguidry Yup, all good! |
Taking GITHUB_TOKEN as a input is a feature available from v1.0, but the example is suggesting v0.2.1 and that expects the token given as an env var.
The text was updated successfully, but these errors were encountered: