This repository has been archived by the owner on Dec 26, 2020. It is now read-only.
Add 'all', 'local', 'yes', 'no' options support for AllowTcpForwarding variable #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @brnck, thanks for this.
Yes, definetly. If you want, you can change it and remove the boolean. |
…g variable Signed-off-by: Augustas Berneckas <a.berneckas@gmail.com>
Signed-off-by: Augustas Berneckas <a.berneckas@gmail.com>
|
Okay so I've dropped support for booleans. However we're still handling case before 6.2 and after or equal 6.2 I guess tests are not failing due to my changes? |
|
Thanks, looks good! Yes, the failing tests are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of a feature request #255
I guess this requires a discussion since I've decided to support both ways to maintain backwards compatibility.
IMHO we should drop boolean and only support string values