Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate testing for telnetd instead of rsh #97

Closed
aavetis opened this issue Jul 19, 2018 · 2 comments · Fixed by #98
Closed

Duplicate testing for telnetd instead of rsh #97

aavetis opened this issue Jul 19, 2018 · 2 comments · Fixed by #98

Comments

@aavetis
Copy link
Contributor

aavetis commented Jul 19, 2018

https://github.com/dev-sec/linux-baseline/blob/master/controls/package_spec.rb#L39-L55

package-02 and package-03 seem to both be testing for telnetd, but seems like it intends to test for rsh.

control 'package-02' do
  impact 1.0
  title 'Do not install Telnet server'
  desc 'Telnet protocol uses unencrypted communication, that means the password and other sensitive data are unencrypted. http://www.nsa.gov/ia/_files/os/redhat/rhel5-guide-i731.pdf, Chapter 3.2.2'
  describe package('telnetd') do
    it { should_not be_installed }
  end
end

control 'package-03' do
  impact 1.0
  title 'Do not install rsh server'
  desc 'The r-commands suffers same problem as telnet. http://www.nsa.gov/ia/_files/os/redhat/rhel5-guide-i731.pdf, Chapter 3.2.3'
  describe package('telnetd') do
    it { should_not be_installed }
  end
end
@chris-rock
Copy link
Member

@aavetis Thank you for this finding. Would you like to open a PR to fix this?

@aavetis
Copy link
Contributor Author

aavetis commented Jul 19, 2018

yep @chris-rock - just made #98; wasn't sure the package name off the top of my head :X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants