Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feat ]: Add session flash message for new code requests. #24

Closed
andersr opened this issue Oct 3, 2023 · 4 comments
Closed

[ Feat ]: Add session flash message for new code requests. #24

andersr opened this issue Oct 3, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@andersr
Copy link

andersr commented Oct 3, 2023

Currently, it appears there is no feedback in the UI when a new OTP is requested, ie something like a "New Code Sent" flash message.

One way to enable this would be to set a session flash message once when a the TOTP is re-sent.

Thoughts?

@dev-xo
Copy link
Owner

dev-xo commented Oct 3, 2023

Sounds good to me @andersr.
It'll improve user experience and minimize client-side state management.

Thank you for the feedback!

@dev-xo dev-xo changed the title Feature request: Set a flash message when a new code is requested [ Feat ]: Add session flash message for new code requests. Oct 3, 2023
@dev-xo dev-xo added the enhancement New feature or request label Oct 3, 2023
@shyamlohar
Copy link

@dev-xo I can help with this. Should I go ahead and send Pull request for same?

@dev-xo
Copy link
Owner

dev-xo commented Dec 28, 2023

Absolutely, @shyamlohar! Feel free to open a PR on it!

@mw10013
Copy link
Collaborator

mw10013 commented Dec 28, 2023

@andersr: The title of your issue seems to focus on new code requests while the body of the issue mentions re-sent codes. New code logic is a bit separated from re-sent code logic. So anything flashy done with re-sent codes would not necessarily appear with new code requests.

Can you walk us through the new code and re-sent code flow that you are trying to achieve and where remix-auth-totp is not helpful. Any details on the /verify loader/action would be very helpful to see.

We are currently discussing PR #40 which may be relevant and feel free to join the discussion.

@dev-xo dev-xo closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants