Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clique: Swapping members mid-combat #2

Open
Mushoz opened this issue Jul 13, 2021 · 3 comments
Open

Clique: Swapping members mid-combat #2

Mushoz opened this issue Jul 13, 2021 · 3 comments

Comments

@Mushoz
Copy link

Mushoz commented Jul 13, 2021

In classic, members are often switched from group to group in order to benefit multiple times from bloodlust / heroism. This addon doesn't seem to take this into account by queuing it up and executing the changes after combat has ended, like it does with other changes (such as people joining/leaving).

When a member is switched in combat, with or without this addon, the two switched members are now also switched when using Clique to mouseover heal. For example, if person A is swapped with person B, mouseover healing A will heal B instead and vice versa. This has let me to spam heal a random shaman over the tank multiple times now, which sometimes ends badly :)

@dev7355608
Copy link
Owner

I'm not sure if the Clique compatibility issue will be ever resolved or if it is actually possible.

@Mushoz
Copy link
Author

Mushoz commented Jul 14, 2021

It's not a compatibility issue though, since it's also happening when Blizzard Raid Frames Fix is disabled. As far as I understand this correctly, any action that is done during combat which would result in illegal API access is queued up by this Addon, and then executed AFTER combat, correct? So for example, if a new member joins the raid during a fight, it will simply not show up, until after combat.

Swapping members obviously runs into similar issues as adding members is, so wouldn't we be able to solve this in the same way? Eg, if members are swapped during combat, the raid frames will simply not reflect those changes and queue these changes up. Once combat ends, the visual changes are applied to the raid frames.

@dev7355608
Copy link
Owner

I'm a little confused now: If Blizzard Raid Frames Fix is enabled, the layout of the frames should not change (or break) in combat; only after combat ends. It should work with group swapping as well. Is that working (with Clique disabled)? I thought the frames worked properly, and only Clique macros break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants