Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build JS files into a bundle to reduce requests #11

Open
346184 opened this issue Sep 5, 2023 · 0 comments
Open

Build JS files into a bundle to reduce requests #11

346184 opened this issue Sep 5, 2023 · 0 comments

Comments

@346184
Copy link

346184 commented Sep 5, 2023

Hey! While debugging the large number of requests causing infrastructure issues when loading into Foundry, I saw that the module currently needs 34 requests for me on each load into Foundry:

34 limits
# 1 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/styles/config.css
# 2 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/index.js
# 3 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/extensions/drawing.mjs
# 4 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/extensions/scene.mjs
# 5 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/extensions/template.mjs
# 6 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/extensions/tile.mjs
# 7 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/patches/light.mjs
# 8 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/patches/sight.mjs
# 9 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/patches/sound.mjs
# 10 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/const.mjs
# 11 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/constraint.mjs
# 12 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/volume.mjs
# 13 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/extension.mjs
# 14 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/data/models.mjs
# 15 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/_index.mjs
# 16 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/utils/shape.js
# 17 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/config.mjs
# 18 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/data/fields.mjs
# 19 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/boundaries/_index.mjs
# 20 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/boundary.mjs
# 21 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/caster.mjs
# 22 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/figure.mjs
# 23 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/figures/_index.mjs
# 24 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/operation.mjs
# 25 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/volume.mjs
# 26 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/boundaries/cylinder.mjs
# 27 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/hit.mjs
# 28 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/math.mjs
# 29 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/figures/circle.mjs
# 30 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/figures/ellipse.mjs
# 31 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/figures/polygon.mjs
# 32 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/figures/rectangle.mjs
# 33 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/scripts/raycasting/figures/tile.mjs
# 34 -> https://assets.forge-vtt.com/bazaar/modules/limits/1.0.2/lang/en.json

Would be nice if you could bundle the JS files with a build step when distributing, so they are not all separate HTTP requests. If everyone does this, even 10 modules require 340 HTTP requests, and some people tend to have way more modules.

Thanks for the amazing module. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant