Caching the generated images

[Mitch528]

It would probably be a good idea to keep the images that are generated for a certain period of time so we're not generating a new image on every request. The image is also being overridden on each request and this can cause exceptions when the file is locked if there are concurrent requests.

Also, the file is named the same regardless of what the subtext is, which can cause conflicts if we were to cache the images. I think to resolve the naming conflicts, we can append a md5 hash of the subtext to the end of the filename.

[Kimmax]

You're absolutely right
We als should cache the devRant avatars to take some load of the devRant avatar servers (I think they render them on every request)
Should also speed things up a lot.
About the filename, I'm not sure. We could also create a subfolder for each user and save using a guid.
But either way - I'm fine with that.

[Mitch528]

The problem with using a guid is that we wouldn't be able to find out which file is associated with the specified subtext.

Not really sure why that line would cause a memory leak though.

[Kimmax]

Leak is taken care off, internale issue in the image library.
I agree with the GUID association. However I think we should stick to one saved / cached banner per user for now..
We can add more variations later, but let's keep it simple for the basics

[Mitch528]

Alright. If we're just going to do it per-user then caching may not make sense for the moment though. Otherwise, the subtext would not be able to be changed once it's been cached.

[Kimmax]

Oh.. you're absolutely right.
Well let's skip the caching for users part for now and look into the avatar caching next
After that we should implement some sort of settings class to pass into the generator for the various options to come

[Kimmax]

Avatar caching is in place. Keeping this issue on low prio for future banner caching

[cozyplanes]

Isn't banner cached already? It seems the banners are saved in /generated.

[Kimmax]

the least created one, yes