Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table icon #79

Closed
cristian-araujo opened this issue Sep 24, 2022 · 6 comments
Closed

Table icon #79

cristian-araujo opened this issue Sep 24, 2022 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@cristian-araujo
Copy link

Describe the bug
Icon table migration is not in the repository and it is necessary for tickets types.

To Reproduce
Clone repository, configure database and run migrations

Expected behavior
Migration for icon table

Screenshots
image

@heloufir
Copy link
Contributor

heloufir commented Sep 24, 2022

As described in the docs, the 5th step of installation, you need to execute the database seeder, in this step the icons table is created and filled with data:

  1. Database seed: using the docker terminal for laravel.test-1 container run this command
php artisan db:seed

https://laravel-help-desk.herokuapp.com/docs/#idocs_installation

@heloufir heloufir self-assigned this Sep 24, 2022
@heloufir heloufir added the documentation Improvements or additions to documentation label Sep 24, 2022
@cristian-araujo
Copy link
Author

cristian-araujo commented Sep 24, 2022

As described in the docs, the 5th step of installation, you need to execute the database seeder, in this step the icons table is created and filled with data:

  1. Database seed: using the docker terminal for laravel.test-1 container run this command
php artisan db:seed

https://laravel-help-desk.herokuapp.com/docs/#idocs_installation

thank you for the fast response.

I think a create table inside a seeder is not the proper way

@heloufir
Copy link
Contributor

heloufir commented Sep 24, 2022

Yes I totally agree with you, an improvement of the icons function is in progress, it will have a migration for the schema and an update of seeder to have all the icons list of the latest fontawesome icons.

@heloufir
Copy link
Contributor

@cristian-araujo
A PR was made to migrate the icons schema definition to a migration, and also the seeder of fontawesome icons list is updated to the last set (based on the metadata https://github.com/FortAwesome/Font-Awesome/blob/master/metadata/icons.json)

PR: #80

@heloufir heloufir added the enhancement New feature or request label Sep 24, 2022
@cristian-araujo
Copy link
Author

cristian-araujo commented Sep 24, 2022

@cristian-araujo A PR was made to migrate the icons schema definition to a migration, and also the seeder of fontawesome icons list is updated to the last set (based on the metadata https://github.com/FortAwesome/Font-Awesome/blob/master/metadata/icons.json)

PR: #80

thank you, I think this help desk has much potential, but in a real scenario it need to be improve a little more.

I have some ideas for it, I was thinking to fork this project and make the changes by myself but if you want, I can share the improvements.

sorry for my english, i'm still learning it

@heloufir
Copy link
Contributor

heloufir commented Sep 24, 2022

Any contribution (idea, code, …) helping to improve this application will be great.
You can use the discussion section of this repository to share ideas, or make pull request as you like.

Thank you in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants