Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities type #19

Closed
mihaisolomon opened this issue Jan 5, 2023 · 8 comments · Fixed by #25
Closed

Activities type #19

mihaisolomon opened this issue Jan 5, 2023 · 8 comments · Fixed by #25
Assignees
Labels
enhancement New feature or request idea New idea to implement

Comments

@mihaisolomon
Copy link
Collaborator

I worked previously on a timesheet app combined with a ticket management. And we had activities attached to the logged hours. We had something like this

  • Programming
  • Testing
  • Learning
  • Research
  • etc ...

It will help on reporting at the end of a month to see how many hours were spent in developing testing etc.

@heloufir
Copy link
Contributor

heloufir commented Jan 5, 2023

Hello @mihaisolomon
This is a good idea, I am planning to add a timesheet module to the application (as you can see in the issue there is one for timesheet)
For the activity type, it's attached to the ticket, so we will have at the end ticket type, priority and activity type?

@mihaisolomon
Copy link
Collaborator Author

The activity type will be added to the logged time. Because in a ticket you will have multiple people working on it and they will have different activities.

@mihaisolomon
Copy link
Collaborator Author

I will make a PR later this week with what I have in mind.

@heloufir
Copy link
Contributor

heloufir commented Jan 5, 2023

The activity type will be added to the logged time. Because in a ticket you will have multiple people working on it and they will have different activities.

Oh I see that makes sense.
I will convert this issue to a task in the roadmap, I think it will give a great value to the app.

Thanks a gain, and feel free to add more details if you want

@heloufir heloufir added enhancement New feature or request idea New idea to implement labels Jan 5, 2023
@heloufir
Copy link
Contributor

heloufir commented Jan 5, 2023

I will make a PR later this week with what I have in mind.

Great thanks for your help

@mihaisolomon
Copy link
Collaborator Author

Check PR: #25

@heloufir
Copy link
Contributor

heloufir commented Jan 9, 2023

I will do it ASAP, thanks for helping

@heloufir heloufir linked a pull request Jan 9, 2023 that will close this issue
@heloufir
Copy link
Contributor

heloufir commented Jan 9, 2023

@mihaisolomon
Just merge the PR, I added some dev:

  • ActivityPolicy and the related permissions, to secure the ActivityResource
  • Add the SoftDeletes to the Activity migration and model

Otherwise the rest is just perfect.
Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request idea New idea to implement
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants