[SKiDL BUG] svg skin not compatible with netlistsvg #118
Labels
Comments
|
Please check and make sure you're using the most recent version of netlistsvg (version 1.0.2 on my system). This error looks similar to problems I encountered when developing the SVG code for SKiDL and I made a PR to netlistsvg to solve it. You can download the latest code from the repo with: npm install github:nturley/netlistsvg |
|
I have already tested with V1.0.2 same error: svg: <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:s="https://github.com/nturley/netlistsvg"> <s:properties constants="false" splitsAndJoins="false" genericsLaterals="true"> <s:layoutEngine org.eclipse.elk.layered.spacing.nodeNodeBetweenLayers="5" org.eclipse.elk.layered.compaction.postCompaction.strategy="4" org.eclipse.elk.spacing.nodeNode= "50" org.eclipse.elk.direction="DOWN"/> </s:properties><style>svg { stroke: #000; fill: none; stroke-linejoin: round; stroke-linecap: round;}text { fill: #000; stroke: none; font-size: 10px; font-weight: bold; font-family: "Courier New", monospace;}.skidl_text { fill: #999; stroke: none; font-weight: bold; font-family: consolas, "Courier New", monospace;}.pin_num_text { fill: #840000;}.pin_name_text { fill: #008484;}.net_name_text { font-style: italic; fill: #840084;}.part_text { fill: #840000;}.part_ref_text { fill: #008484;}.part_name_text { fill: #008484;}.pen_fill { fill: #840000;}.background_fill { fill: #FFFFC2}.nodelabel { text-anchor: middle;}.inputPortLabel { text-anchor: end;}.splitjoinBody { fill: #000;}.symbol { stroke-linejoin: round; stroke-linecap: round; stroke: #840000;}.detail { stroke-linejoin: round; stroke-linecap: round; fill: #000;}</style><!-- signal --><g s:type="inputExt" s:width="30" s:height="20" transform="translate(0,0)"> <text x="-2" y="12" text-anchor='end' class="$cell_id pin_name_text" s:attribute="ref">input</text> <s:alias val="$_inputExt_"/> <path d="M0,0 V20 H15 L30,10 15,0 Z" class="$cell_id symbol"/> <g s:x="30" s:y="10" s:pid="Y" s:position="right"/></g><g s:type="outputExt" s:width="30" s:height="20" transform="translate(0,0)"> <text x="32" y="12" class="$cell_id pin_name_text" s:attribute="ref">output</text> <s:alias val="$_outputExt_"/> <path d="M30,0 V20 H15 L0,10 15,0 Z" class="$cell_id symbol"/> <g s:x="0" s:y="10" s:pid="A" s:position="left"/></g><!-- signal --><!-- builtin --><g s:type="generic" s:width="30" s:height="40" transform="translate(0,0)"> <text x="15" y="-4" class="nodelabel $cell_id" s:attribute="ref">generic</text> <rect width="30" height="40" x="0" y="0" s:generic="body" class="$cell_id"/> <g transform="translate(30,10)" s:x="30" s:y="10" s:pid="out0" s:position="right"> <text x="5" y="-4" class="$cell_id">out0</text> </g> <g transform="translate(30,30)" s:x="30" s:y="30" s:pid="out1" s:position="right"> <text x="5" y="-4" class="$cell_id">out1</text> </g> <g transform="translate(0,10)" s:x="0" s:y="10" s:pid="in0" s:position="left"> <text x="-3" y="-4" class="inputPortLabel $cell_id">in0</text> </g> <g transform="translate(0,30)" s:x="0" s:y="30" s:pid="in1" s:position="left"> <text x="-3" y="-4" class="inputPortLabel $cell_id">in1</text> </g></g><!-- builtin -->
<g s:type="MPMOS_1_HR" s:width="144.0" s:height="132.0" >
<s:alias val="MPMOS_1_HR"/>
<g transform="translate(72.0,60.0)">
<path d="M 0.0 -60.0 L 7.5 -37.5 L -7.5 -37.5 L 0.0 -60.0" style="stroke-width:1.0" class="$cell_id symbol pen_fill" />
<path d="M 30.0 15.0 L -30.0 15.0" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M -30.0 7.5 L -30.0 -30.0" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M 30.0 -30.0 L 30.0 7.5" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M 0.0 -60.0 L 0.0 7.5" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M -30.0 7.5 L 30.0 7.5" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M -72.0 -30.0 L -30.0 -30.0" style="stroke-width:1.0" class="$cell_id symbol"/>
<text class='pin_num_text' text-anchor='end' x='-30.0' y='-30.0' transform='rotate(0 -30.0 -30.0) translate(-6.0 -2.25)' style='font-size:15.0px' > 1 </text>
<text class='pin_name_text' text-anchor='start' x='-30.0' y='-30.0' transform='rotate(0 -30.0 -30.0) translate(6.0 3.0)' style='font-size:15.0px' > D </text>
<path d="M 0.0 72.0 L 0.0 15.0" style="stroke-width:1.0" class="$cell_id symbol"/>
<text class='pin_num_text' text-anchor='end' x='0.0' y='15.0' transform='rotate(-90 0.0 15.0) translate(-6.0 -2.25)' style='font-size:15.0px' > 2 </text>
<text class='pin_name_text' text-anchor='start' x='0.0' y='15.0' transform='rotate(-90 0.0 15.0) translate(6.0 3.0)' style='font-size:15.0px' > G </text>
<path d="M 72.0 -30.0 L 30.0 -30.0" style="stroke-width:1.0" class="$cell_id symbol"/>
<text class='pin_num_text' text-anchor='start' x='30.0' y='-30.0' transform='rotate(0 30.0 -30.0) translate(6.0 -2.25)' style='font-size:15.0px' > 3 </text>
<text class='pin_name_text' text-anchor='end' x='30.0' y='-30.0' transform='rotate(0 30.0 -30.0) translate(-6.0 3.0)' style='font-size:15.0px' > S </text>
<path d="M 60.0 -60.0 L 0.0 -60.0" style="stroke-width:1.0" class="$cell_id symbol"/>
<text class='pin_num_text' text-anchor='start' x='0.0' y='-60.0' transform='rotate(0 0.0 -60.0) translate(6.0 -2.25)' style='font-size:15.0px' > 4 </text>
<text class='pin_name_text' text-anchor='end' x='0.0' y='-60.0' transform='rotate(0 0.0 -60.0) translate(-6.0 3.0)' style='font-size:15.0px' > B </text>
<text class='part_ref_text' text-anchor='start' x='15.0' y='-90.0' transform='rotate(-90 15.0 -90.0) translate(-7.5 0.0)' style='font-size:15.0px' s:attribute="ref" > X </text>
<text class='part_name_text' text-anchor='start' x='-15.0' y='-90.0' transform='rotate(-90 -15.0 -90.0) translate(-7.5 0.0)' style='font-size:15.0px' s:attribute="value" > X </text>
</g>
<g s:x="0.0" s:y="30.0" s:pid="1" s:position="left"/>
<g s:x="72.0" s:y="132.0" s:pid="2" s:position="bottom"/>
<g s:x="144.0" s:y="30.0" s:pid="3" s:position="right"/>
<g s:x="132.0" s:y="0.0" s:pid="4" s:position="right"/>
</g>
<g s:type="PMOS_GSD_1_" s:width="112.5" s:height="132.0" >
<s:alias val="PMOS_GSD_1_"/>
<g transform="translate(60.0,72.0)">
<path d="M 27.0 0.0 L 15.0 -4.5 L 15.0 4.5 L 27.0 0.0" style="stroke-width:1.0" class="$cell_id symbol pen_fill" />
<circle cx="19.5" cy="0.0" r="33.0" style="stroke-width:3.0" class="$cell_id symbol " />
<path d="M 3.0 0.0 L -30.0 0.0" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M 3.0 -22.5 L 3.0 22.5" style="stroke-width:3.0" class="$cell_id symbol " />
<path d="M 9.0 21.0 L 30.0 21.0" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M 9.0 15.0 L 9.0 27.0" style="stroke-width:3.0" class="$cell_id symbol " />
<path d="M 9.0 -6.0 L 9.0 6.0" style="stroke-width:3.0" class="$cell_id symbol " />
<path d="M 9.0 -21.0 L 30.0 -21.0" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M 9.0 -27.0 L 9.0 -15.0" style="stroke-width:3.0" class="$cell_id symbol " />
<path d="M 30.0 -30.0 L 30.0 -21.0" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M 30.0 30.0 L 30.0 0.0 L 9.0 0.0" style="stroke-width:1.0" class="$cell_id symbol " />
<path d="M -60.0 0.0 L -30.0 0.0" style="stroke-width:1.0" class="$cell_id symbol"/>
<text class='pin_num_text' text-anchor='end' x='-30.0' y='0.0' transform='rotate(0 -30.0 0.0) translate(-6.0 -2.25)' style='font-size:15.0px' > 1 </text>
<path d="M 30.0 60.0 L 30.0 30.0" style="stroke-width:1.0" class="$cell_id symbol"/>
<text class='pin_num_text' text-anchor='end' x='30.0' y='30.0' transform='rotate(-90 30.0 30.0) translate(-6.0 -2.25)' style='font-size:15.0px' > 2 </text>
<path d="M 30.0 -72.0 L 30.0 -30.0" style="stroke-width:1.0" class="$cell_id symbol"/>
<text class='pin_num_text' text-anchor='start' x='30.0' y='-30.0' transform='rotate(-90 30.0 -30.0) translate(6.0 -2.25)' style='font-size:15.0px' > 3 </text>
<text class='part_ref_text' text-anchor='start' x='60.0' y='-15.0' transform='rotate(0 60.0 -15.0) translate(0.0 7.5)' style='font-size:15.0px' s:attribute="ref" > X </text>
<text class='part_name_text' text-anchor='start' x='60.0' y='15.0' transform='rotate(0 60.0 15.0) translate(0.0 7.5)' style='font-size:15.0px' s:attribute="value" > X </text>
</g>
<g s:x="0.0" s:y="72.0" s:pid="1" s:position="left"/>
<g s:x="90.0" s:y="132.0" s:pid="2" s:position="bottom"/>
<g s:x="90.0" s:y="0.0" s:pid="3" s:position="top"/>
</g>
</svg>json net list: {
"modules": {
"": {
"cells": {
"M1": {
"attributes": {
"value": "MPMOS"
},
"connections": {
"1": [
1
],
"2": [
1
],
"3": [
2
]
},
"port_directions": {
"1": "input",
"2": "input",
"3": "input",
"4": "input"
},
"type": "MPMOS_1_HR"
},
"Q1": {
"attributes": {
"value": "PMOS_GSD"
},
"connections": {
"3": [
2
]
},
"port_directions": {
"1": "input",
"2": "input",
"3": "input"
},
"type": "PMOS_GSD_1_"
}
},
"ports": {}
}
}
}I'm at a loss. |
|
If you can provide enough source/instructions for me to recreate the problem, I can take a look at it. |
|
above: python: from skidl import *
mosfet = Part("pspice","MPMOS")
mosfet.symtx = "HR"
pmos = Part("DeviceSteffen","PMOS_GSD")
n01=Net("n01")
mosfet[1] += mosfet[2]
n01 += mosfet[3]
pmos[3] += mosfet[3]
generate_svg()
just test on your system. |
|
A work around: --- /home/dunkelwind/Schreibtisch/kicad.py 2021-07-06 06:14:53.036493000 +0200
+++ /home/dunkelwind/.local/lib/python3.6/site-packages/skidl/tools/kicad.py 2021-07-09 10:41:47.357593639 +0200
@@ -1603,24 +1603,25 @@
's:type="{symbol_name}"',
's:width="{bbox.w}"',
's:height="{bbox.h}"',
- ">",
+ # ">",
]
).format(**locals())
)
- # Add part alias.
- svg.append('<s:alias val="{symbol_name}"/>'.format(**locals()))
-
# Group text & graphics and translate so bbox.min is at (0,0).
translate = bbox.min * -1
svg.append(
- '<g transform="translate({translate.x},{translate.y})">'.format(**locals())
+ ' transform="translate({translate.x},{translate.y})">'.format(**locals())
)
+
+ # Add part alias.
+ svg.append('<s:alias val="{symbol_name}"/>'.format(**locals()))
+
# Add part unit text and graphics.
svg.extend(unit_filled_svg[unit]) # Filled items go on the bottom.
svg.extend(unit_svg[unit]) # Then unfilled items.
svg.extend(unit_txt_svg[unit]) # Text comes last.
- svg.append("</g>")
+ # svg.append("</g>")
# Place a visible bounding-box around symbol for trouble-shooting.
show_bbox = False
@@ -1643,7 +1644,7 @@
# Keep the pins out of the grouped text & graphics but adjust their coords
# to account for moving the bbox.
for pin_info in unit_pin_info[unit]:
- pin_pt = Point(pin_info.x, pin_info.y) + translate
+ pin_pt = Point(pin_info.x, pin_info.y)# + translate
side = pin_info.side
pid = pin_info.pid
pin_svg = '<g s:x="{pin_pt.x}" s:y="{pin_pt.y}" s:pid="{pid}" s:position="{side}"/>'.format(
But I don't know if that's the right way... |
Dunkelwind
changed the title
|
I had a real hard time getting your example (or any example) to work because of my installation of So I completely removed from skidl import *
mosfet = Part("pspice","MPMOS")
mosfet.symtx = "HL" # Had a problem using "R" rotations.
#pmos = Part("DeviceSteffen","PMOS_GSD") # I don't have this library.
pmos = Part("pspice","MPMOS") # I substituted this part.
n01=Net("n01")
mosfet[1] += mosfet[2]
n01 += mosfet[3]
pmos[3] += mosfet[3]
generate_svg()So I think you shouldn't need your work-around if you get the latest version of One problem did arise when the second PMOS transistor in your example was rotated to the right: the If you think your problems might also be caused by an out-of-date installation of cd ~
sudo apt remove node npm nodejs
sudo rm -rf /usr/local/bin/npm
sudo rm -rf /usr/local/share/man/man1/node*
sudo rm -rf /usr/local/lib/dtrace/node.d
rm -rf ~/.npm
rm -rf ~/.node-gyp
sudo rm -rf /opt/local/bin/node
sudo rm -rf /opt/local/include/node
sudo rm -rf /opt/local/lib/node_modules
sudo rm -rf /usr/local/lib/node*
sudo rm -rf /usr/local/include/node*
sudo rm -rf /usr/local/bin/node*
curl -sL https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.0/install.sh -o install_nvm.sh
bash install_nvm.sh
nvm install stable
nvm use stable
npm install nturley/netlistsvgIf you're sure you have the newest version of |
|
Thank you for your effort. |
|
I finally got back to this and verified that your fix works for all my test cases and also solves the problem with the rotated transistor. I've checked the changes into the development branch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
skin.svg file has no correct format for netlistsvg.
netlistsvg error:
I think s:pid should be in the same root tag
i.e.
not working because extra <g transform...:
The text was updated successfully, but these errors were encountered: