Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module description not set correctly. #2

Closed
ngetchell opened this issue Oct 5, 2018 · 4 comments
Closed

Module description not set correctly. #2

ngetchell opened this issue Oct 5, 2018 · 4 comments

Comments

@ngetchell
Copy link
Contributor

ngetchell commented Oct 5, 2018

When invoking plaster using the stucco template you are prompted to set a description but it never makes it to the PSD1 file.

Expected Behavior

When prompted for a description, it should carry over to the PSD1 file.

Current Behavior

The psd1 file has a commented out Description with no text.

Possible Solution

There are two different names for the attribute used in the manifest. They are as follows.

    <parameter name='Description'
               type='text'
               prompt='Enter a description of the module'/>
    <newModuleManifest destination='${PLASTER_PARAM_ModuleName}\${PLASTER_PARAM_ModuleName}.psd1'
                       moduleVersion='$PLASTER_PARAM_Version'
                       rootModule='${PLASTER_PARAM_ModuleName}.psm1'
                       author='$PLASTER_PARAM_FullName'
                       description='$PLASTER_PARAM_ModuleDesc'
                       encoding='UTF8-NoBOM'/>

I tried setting the variables to the same name but no luck.

Steps to Reproduce (for bugs)

$Template = Get-PlasterTemplate -Path .\Output\Stucco\0.1.0\plasterManifest.xml
Invoke-Plaster -TemplatePath $template.TemplatePath -DestinationPath "c:\users\ngetchell\documents\git\Example3"

Context

Luckily the pester tests catch the error.

Your Environment

  • Module version used: 0.1.0
  • Operating System: Microsoft Windows 10.0.17763
  • PowerShell version: 6.1.0
@ngetchell
Copy link
Contributor Author

Note: when setting a default value in the manifest that also fails to make it to the psd1 file. I think there may be an issue with Plaster itself.

@devblackops
Copy link
Owner

I noticed this last night but didn't push my changes. Try now.

@ngetchell
Copy link
Contributor Author

We came to the same conclusion. The push fixes this for me.

@ngetchell
Copy link
Contributor Author

Resolved by the latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants