Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First entry is automatically selected #22

Closed
xenon20 opened this issue Jan 8, 2013 · 7 comments
Closed

First entry is automatically selected #22

xenon20 opened this issue Jan 8, 2013 · 7 comments

Comments

@xenon20
Copy link

xenon20 commented Jan 8, 2013

First let me say thanks for this great addon.
Just updated to the latest version 1.15 and now the first entry is automatically selected when entering some chars. So when I press return, the first item is used and I cannot search for "wat", if the first item is "watch".

@tkirda
Copy link
Member

tkirda commented Jan 8, 2013

Latest version is actually 1.2. You can press escape to kill suggestions. Would it make sense to add configuration option if you don't need first item to be selected by default?

@xenon20
Copy link
Author

xenon20 commented Jan 8, 2013

Sorry, I meant version 1.2. In older versions, autocomplete didn't behave like this. Sometimes people don't even look in the list. If someone wants to search for all shops that offer watches, they cannot enter "watches" and press enter, when the first item is "watches eshop", the second maybe "watches store" and so on. they always get to "watches eshop". Maybe I explained it too detailed, I think you already understood what I meant before...so an option for this would be great ;)

@ghost
Copy link

ghost commented Jan 17, 2013

I would also really like to see a configuration option to prevent the first item from being selected by default. The current behaviour makes it pretty difficult to not select an item from the suggested list.

@tkirda
Copy link
Member

tkirda commented Jan 18, 2013

Will add it soon. The fact that it selects item when you click outside the box and it selects the entry is filed as a bug.

@tkirda
Copy link
Member

tkirda commented Jan 20, 2013

This has been fixed in the following commit: 56437a2

Also default value is false, so it will not select first item by default.

@tkirda tkirda closed this as completed Jan 20, 2013
@ghost
Copy link

ghost commented Jan 20, 2013

Will you be doing a release soon that includes this fix, or should I just replace my version of jquery.autocomplete.js with the current version in the master branch. Thanks for resolving this so quickly.

@tkirda
Copy link
Member

tkirda commented Jan 21, 2013

Just release v1.2.2. Grab it here: https://github.com/devbridge/jQuery-Autocomplete/tree/master/dist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants