Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented custom accent theme selection #141

Merged
merged 4 commits into from Jul 14, 2020

Conversation

Deepanshu-Rohilla
Copy link
Member

  1. Implemented custom accent theme selection from settings. Showed a palette for various colors.
  2. Available theme selection are: light, dark and follow system. Follow system will adapt the mobile theme (dark or light). Note that if we change the theme of mobile while follow system is chosen, it would automatically adapt to the change.
  3. Unfortunately, Theme color does not apply to current page icon while switching between themes #91 is still there. However, effect is almost negligible. It is slightly significant if someone choose two completely different colors. Good thing is that it is gone when someone switch between themes (because color remains same).
    This is how the app looks in various themes:

WhatsApp Video 2020-07-13 at 12 51 33 AM

@kshitijalwadhi
Copy link
Member

Terrific work. 🤩

A few things that you can look into:

  • When the user has requested for a group, the border of that group in tripslist.dart has been hardcoded to pink[300]. And the current group is accent colour. See if you can add a condition on that pink[300] so that it is some other colour in the cases when the accent colour is similar to pink. For other colours it will work fine.
  • See if you can do something to indicate that there are more colours to be selected in that row of accent colours. Maybe add something like a scrollbar?
  • Add a sizedbox after the 'App Theme' tile in settings to make the distance between the tiles same.

@Deepanshu-Rohilla
Copy link
Member Author

WhatsApp Image 2020-07-13 at 2 13 34 PM

  1. Adjusted the spacing between widgets.
  2. Specified color themes wherever required (on sign in, register etc.)
  3. Also fixed Bug Icon position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants