Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added snackbar-enhancement for errors #157

Closed
wants to merge 0 commits into from

Conversation

pr4nshul
Copy link

@pr4nshul pr4nshul commented Nov 9, 2020

Capture
These were the settings available in my IDE, hence some of the code has been reformatted when I used Ctrl+Alt+L. Other than that I have added snackbar , although I had some issues figuring out the context to use with scaffold considering I am new so if any changes are required please tell me, and if I have missed any catch phrase with error in the code where snackbar wasn't already present or added by me. I can also upload .txt file if needed which mentions all the files in which I have made a change.

@Deepanshu-Rohilla
Copy link
Member

Hi Pranshul. Thanks for contributing. Please make sure hard wrap is set to 900 while formatting as currently it is very difficult to review the changed files.
Have a look at https://github.com/devclub-iitd/ShareACab/blob/master/CONTRIBUTING.md for more info.
There are links to set the hard wrap for Android Studio and VS Code. In case you are using some other IDE, look for the wrapping section in settings.

@pr4nshul
Copy link
Author

I have closed this and created a new PR , as per your guidelines please review and let me know if still some issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants