New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Hero Animations #86
Implemented Hero Animations #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is because on the next screen the document where Hero class is applied is visible only after loading. Make sure atleast the name of group is passed from main screen and then there on second screen all the time (even during loading phase). Apply Hero class on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's still not working. The title appears late after black screen thus no animation.
Have app bar always appear (pass title value from one screen to another so you always have title value) and loading icon below the app bar.
20359b1
to
37855db
Compare
final userDetails = await Firestore.instance | ||
.collection('group') | ||
.document(docId) | ||
.collection('users') | ||
.getDocuments(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the formatting. Hard wrap is not set to 900
Firestore.instance | ||
.collection('userdetails') | ||
.document(currentuser.uid) | ||
.get() | ||
.then((value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also here
Btw can you explore, why on clicking the back button there is no animation ? Genrally in Hero class there is animation both on opening the page and closing the page |
a7799f0
to
324bdc9
Compare
Firestore.instance | ||
.collection('userdetails') | ||
.document(currentuser.uid) | ||
.get() | ||
.then((value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting is still not fixed. Make the hard wrap to 900
Fixes #89 |
3b96a0b
to
f2238c4
Compare
8b6f6b5
to
fbe187f
Compare
Some points to note about this change: