Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Hero Animations #86

Merged
merged 11 commits into from Jun 11, 2020

Conversation

Deepanshu-Rohilla
Copy link
Member

Some points to note about this change:

  1. While clicking on the group, the animations sometimes create a laggy effect. However, it is nice while reverting back to dashboard.
  2. The loading after clicking on the group card sometimes reduces the laggy effect.
  3. I have implemented only on dashboard to know the effects on UI. If everything goes right, we can implement it in other areas also (for example, in opening chat of any group)
    WhatsApp Video 2020-06-07 at 1 52 54 AM

@arpit-saxena arpit-saxena added this to In progress in PR Board via automation Jun 7, 2020
Copy link
Member

@tmibvishal tmibvishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is because on the next screen the document where Hero class is applied is visible only after loading. Make sure atleast the name of group is passed from main screen and then there on second screen all the time (even during loading phase). Apply Hero class on that

PR Board automation moved this from In progress to Review in progress Jun 7, 2020
@Deepanshu-Rohilla
Copy link
Member Author

  1. Removed the loading circular animation which was causing the laggy effect.
  2. Implemented the sliver app.
  3. Removed the scrolling issue that came up today.
  4. Modified the button in the bottom (text was not clearly visible)
    WhatsApp Video 2020-06-07 at 11 17 15 PM
    WhatsApp Image 2020-06-07 at 11 18 34 PM
    WhatsApp Image 2020-06-07 at 11 24 18 PM

Copy link
Member

@tmibvishal tmibvishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's still not working. The title appears late after black screen thus no animation.
Have app bar always appear (pass title value from one screen to another so you always have title value) and loading icon below the app bar.

@Deepanshu-Rohilla
Copy link
Member Author

  1. Fixed the loading issue. Earlier, the card was also inside future builder which was not necessary. Now, the card details are taken from the card in tripslist.dart and it is shown in the group screen.
    This eventually fixed the lagging issue. Only the details of member are shown after loading.
    WhatsApp Video 2020-06-08 at 4 35 54 PM.

Comment on lines +32 to +36
final userDetails = await Firestore.instance
.collection('group')
.document(docId)
.collection('users')
.getDocuments();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the formatting. Hard wrap is not set to 900

Comment on lines +45 to +49
Firestore.instance
.collection('userdetails')
.document(currentuser.uid)
.get()
.then((value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here

@tmibvishal
Copy link
Member

Btw can you explore, why on clicking the back button there is no animation ? Genrally in Hero class there is animation both on opening the page and closing the page

@Deepanshu-Rohilla
Copy link
Member Author

Previous GIF had only opening animations. This one has both the animations (opening and closing)
WhatsApp Video 2020-06-09 at 1 51 43 PM

Comment on lines +45 to +49
Firestore.instance
.collection('userdetails')
.document(currentuser.uid)
.get()
.then((value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting is still not fixed. Make the hard wrap to 900

@Deepanshu-Rohilla
Copy link
Member Author

Fixes #89

@tmibvishal tmibvishal merged commit 3d3ce30 into devclub-iitd:master Jun 11, 2020
PR Board automation moved this from Review in progress to Done Jun 11, 2020
@arpit-saxena arpit-saxena linked an issue Jun 11, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
PR Board
  
Done
Development

Successfully merging this pull request may close these issues.

Trip Details Screen
2 participants