Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Company website as link #55

Closed
claudey opened this issue Feb 5, 2019 · 3 comments
Closed

Show Company website as link #55

claudey opened this issue Feb 5, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@claudey
Copy link
Member

claudey commented Feb 5, 2019

When a user views a company page, that page currently has information about the company. Some of this information is the company website.

Currently the website is just shown as text. Show this website text as link so please can click to go to the company website. More kudos when the website opens in another tab.
@claudey claudey added enhancement New feature or request good first issue Good for newcomers labels Feb 5, 2019
@jadijadi jadijadi mentioned this issue Feb 5, 2019
Merged
@yawboakye
Copy link
Member

@claudey Not something I'm attached to but apparently, opening a new link in a new tab is not as easy as target="_blank". I think it should be fine to use the same tab for this navigation. The user has the choice of using the browser's built-in function to open in a new tab, or go back to the previous page in case they just clicked on the link.

@claudey
Copy link
Member Author

claudey commented Feb 5, 2019

That's fine. 👍

@yawboakye
Copy link
Member

Resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yawboakye @claudey