Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Save-State' Command is Deprecated #180

Closed
andar1an opened this issue Nov 11, 2022 · 6 comments · Fixed by #219
Closed

'Save-State' Command is Deprecated #180

andar1an opened this issue Nov 11, 2022 · 6 comments · Fixed by #219
Assignees

Comments

@andar1an
Copy link
Contributor

The 'save-state' command is deprecated: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I have had to update other actions due to this deprecation as well, if you would like me to update these commands please let me know :).

@andar1an
Copy link
Contributor Author

andar1an commented Nov 13, 2022

The only place I see set-output or save-state is at:

echo "::set-output name=version::$VERSION_MAJOR.$VERSION_MINOR.$VERSION_PATCH"

can be changed to:
echo "version=$VERSION_MAJOR.$VERSION_MINOR.$VERSION_PATCH" >> $GITHUB_OUTPUT

and

echo "::set-output name=version_short::$VERSION_MAJOR.$VERSION_MINOR"

can be changed to:
echo "version_short=$VERSION_MAJOR.$VERSION_MINOR" >> $GITHUB_OUTPUT

If you know of any others please let me know.

Also, if there is somewhere else that I can ask a question about this Repo I would appreciate that.

@joshspicer
Copy link
Member

Also, if there is somewhere else that I can ask a question about this Repo I would appreciate that.

The team is setting up a community Slack channel - more info here: https://github.com/orgs/devcontainers/discussions/3

@joshspicer
Copy link
Member

@stephenandary Thanks for surfacing - we would definitely accept a PR here :)

@andar1an
Copy link
Contributor Author

@stephenandary Thanks for surfacing - we would definitely accept a PR here :)

I put up a PR a few days ago I think :)

@metaskills
Copy link

PR Here: #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@metaskills @stuartleeks @andar1an @joshspicer and others